Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer skip CVR authentication in tests where possible #4101

Open
arsalansufi opened this issue Oct 23, 2023 · 0 comments
Open

No longer skip CVR authentication in tests where possible #4101

arsalansufi opened this issue Oct 23, 2023 · 0 comments

Comments

@arsalansufi
Copy link
Contributor

arsalansufi commented Oct 23, 2023

A search for SKIP_CAST_VOTE_RECORDS_AUTHENTICATION should bring up places where we skip CVR authentication in tests. The CVR fixtures now include signature files, so CVR authentication in tests is now possible.

The one gotcha is tests in which we intentionally modify the export (via modifyCastVoteRecordExport for example). We could have modifyCastVoteRecordExport export an updated signature file.

We may still want to skip CVR auth in some tests for speed. And we should still keep the feature flag around for development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants