Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vxdesign: duplicate candidate IDs generated across contests #4068

Closed
carolinemodic opened this issue Oct 11, 2023 · 1 comment
Closed

vxdesign: duplicate candidate IDs generated across contests #4068

carolinemodic opened this issue Oct 11, 2023 · 1 comment
Assignees
@jonahkagan
Labels
bug vx-design

Comments

@carolinemodic
Copy link
Contributor

https://votingworks.slack.com/archives/CEL6D3GAD/p1696981239570269

Issue automatically created from slack feedback reported by caroline
https://votingworks.slack.com/archives/CJU9MSC6S/p1696981706011659?thread_ts=1696981706.011659&cid=CJU9MSC6S
@mattroe mattroe added bug and removed triage labels Oct 11, 2023
@mattroe mattroe changed the title https://votingworks vxdesign: duplicate candidate IDs generated across contests Oct 11, 2023
@jonahkagan jonahkagan self-assigned this Dec 4, 2023
@jonahkagan
Copy link
Collaborator

Another issue with this form: If you have two candidates with the same ID, the form controls will affect both candidates. This is because we're using the contest ID in the onChange handlers for all of the form controls.

@jonahkagan jonahkagan mentioned this issue Dec 13, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonahkagan jonahkagan

Labels
bug vx-design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonahkagan @mattroe @carolinemodic