Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other discrepencies with 2.0 spec #377

Open
JohnLCaron opened this issue Sep 25, 2023 · 4 comments
Open

Other discrepencies with 2.0 spec #377

JohnLCaron opened this issue Sep 25, 2023 · 4 comments
Labels
waiting-MS Waiting for MS reference library

Comments

@JohnLCaron
Copy link
Collaborator

Catch all for anything in the code needing to be caught up to on the 2.0 spec

@JohnLCaron
Copy link
Collaborator Author

selection sequence numbers should be sequentail in the contest.
"The first selectable option in the list has option index 1." (p.17)

@JohnLCaron
Copy link
Collaborator Author

Fixed in PR #378

@JohnLCaron
Copy link
Collaborator Author

JohnLCaron commented Oct 4, 2023

Hashing strings (5.1.4)

"When an input to the function H is a string s, it is encoded as a byte array b(s, len(s)) using UTF-8
encoding. Here, len(s) is the length of the UTF-8 encoding of the string s in bytes."

But we are just using String.encodeToByteArray().

Works as long as we are consistent, but will break vs conformant implementation.

Affects

  1. ContestData.encryptContestData()
  2. KeyCeremonyTrustee.shareEncryption()
  3. AddEncryptedBallot.closeChain()

@JohnLCaron JohnLCaron added the waiting-MS Waiting for MS reference library label Oct 4, 2023
@JohnLCaron
Copy link
Collaborator Author

Since ContestData format is not specfied, we will disagree with the rust library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-MS Waiting for MS reference library
Projects
None yet
Development

No branches or pull requests

1 participant