Hi,
I understand your commit but I think it's sad to loose some functionnalities on some devices because other devices don't manage them. I mainly use a PC to display the UI, and the hover/leave events are interesting in my case.

I think we should either find a compromise to satisfy both devices, or implement some device-spcific stuff according to the user agent...

I don't see that as losing. We are winning by embracing a global convention, the button shows its action.. That is what #11 arguments.

If you look at older commits, you will see that the behaviour changed several times in the past, because some people think the same as you, other are expecting that the button shows the current state (and I think this is in a big part due to the fact that it's highlighted, it looks like if it was selected ... if something is selected, you expected to see its state, not its action).

Anyway, I tried to do a compromise for both parts : show the current state, and on mouse events show the button action ; but you're right, I didn't think about no-mouse devices. That's why I said I would loose a functionnality with your commit. Maybe the solution would be to do as you say, but in addition, remove this button highlighting that makes it appear as a selected state.

That is right, the current implementation shouldn't have such highlight..
Besides that, I think following the most usual convention is always a win.
The web is changing and the mouse hover events are out of fashion.
There is a tendency of deprecate such events in environments accessed by
both mobile and desktop.

I think the current setup is a bit inconsistent. During playback, the play button shows the play icon, indicating you are playing. But when you are stopped, the play button also shows the play icon.

I'm more inclined to go with the usual standard - have the play button show the pause icon during playback, and have it show the play icon during pause or stop.

Alternatively, we can compromise by making play and pause separate buttons.

@jotak what are your thoughts?

I'm fine with that, if there's no strong argument not to follow convention, then we follow conventions.

Hmm, I have implemented this change on e5d5f81, and it definitely looks ... different. I had to remove the green box which appears around the button so it does not suggest that the icon indicates the current state.

Let me know what you think. If we don't like, we can revert.