Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu is not hidden/opened properly #28

Open
mnordlindh opened this issue Feb 13, 2023 · 0 comments
Open

Menu is not hidden/opened properly #28

mnordlindh opened this issue Feb 13, 2023 · 0 comments

Comments

@mnordlindh
Copy link

There is an issue with the menu not closing/updating its position due to an error in the docClickHandler not actually invoking the hideMenu function.

"docClickHandler = () => this.hideMenu;" should be
"docClickHandler = () => this.hideMenu();"

https://github.com/volser/quill-table-ui/blob/master/src/index.ts#L177

It works in version 1.0.5 (the demo) but not in version 1.0.7.

I can do a PR for this but as it is such a small change its probably easier for you to just update it. Let me know @volser.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mnordlindh