Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync error under Windows #329

Open
graphixillusion opened this issue Mar 30, 2024 · 4 comments
Open

Sync error under Windows #329

graphixillusion opened this issue Mar 30, 2024 · 4 comments

Comments

@graphixillusion
Copy link

Hi there. As the title says i'm getting this error when i try to run the sync command under Windows.

Error: glob::set::parse

x Could not build GlobSet
`-> failed to parse glob expression

I don't know if i'm doing something wrong but i just initialize rotz with rotz init, then add things into the .dotfiles folder and then i've tried the sync command and got this error.

@t-mart
Copy link

t-mart commented Apr 11, 2024

+1 to this. Happy to explain more if questions are asked.

In fact, I'm not really sure what this command is supposed to do... Aren't the deployed dotfiles already linked to the respective file in .dotfiles?

@t-mart
Copy link

t-mart commented Apr 11, 2024

Ah, ok. When I specified a specific dot (e.g., rotz sync aria2), it tried to push something to the origin. However, because I'd already manually git push-ed, the command failed. In other words, rotz was not able to detect that the branch was up-to-date with the origin and gave a non-zero exit code.

If it helps, I just converted my dotfiles repo to rotz at https://github.com/t-mart/dotfiles.

FWIW, this subcommand feels a bit "extra", if it is just a wrapper around git push. It's implied that users are already working with git because rotz clone, the "entrypoint" to rotz, requires an existing repo. Therefore, maybe they could manage these steps with git directly and get full control.

Additionally, it opens up a ton of surface area in understanding the state of a git repository.

  • How does it handle uncommitted work?
  • What if I'm not on the master branch?
  • What if it's called main instead?
  • As stated before, could it better detect if the branch is already up-to-date with the upstream?

I'd like to know more about your philosophy on this one, @volllly.

@volllly
Copy link
Owner

volllly commented Apr 17, 2024

Hey @graphixillusion, the current version has a bug leading to this problem. I'll fix it in a new release soon.

@volllly
Copy link
Owner

volllly commented Apr 17, 2024

Hey, @t-mart,

I agree with you that the sync command is bloat/bad/not worth the effort.
It's something added because I could but without a real need for it 😅 (I tend to do that)

Ideally I'd like the init and clone commands to use the gitoxide or git2 crates (but I'm struggling with getting that working) so you can clone your dotfiles without having git installed and then use rotz to rotz install git.

I've started a poll to get some more feedback on the sync command 😁 Thanks for your input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants