Add placeholder support for e2e and some reclaim cases #898

alcorj-mizar · 2020-07-02T08:36:14Z

No description provided.

1. create placeholder when e2e need different flavor of nodes 2. add reclaim cases when new job comes in Signed-off-by: alcorj.mizar <[email protected]>

TravisBuddy · 2020-07-02T08:37:13Z

Travis tests have failed

Hey @alcorj-mizar,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 382c4b90-bc3f-11ea-937a-75d40a178b7c

TravisBuddy · 2020-07-02T09:54:05Z

Travis tests have failed

Hey @alcorj-mizar,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: f4c4e3c0-bc49-11ea-937a-75d40a178b7c

TravisBuddy · 2020-07-02T10:52:22Z

Travis tests have failed

Hey @alcorj-mizar,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 197416c0-bc52-11ea-937a-75d40a178b7c

TravisBuddy · 2020-07-02T14:25:41Z

Travis tests have failed

Hey @alcorj-mizar,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e66a9d80-bc6f-11ea-937a-75d40a178b7c

TravisBuddy · 2020-07-02T15:22:27Z

Travis tests have failed

Hey @alcorj-mizar,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: bce51000-bc77-11ea-937a-75d40a178b7c

update slot resources Signed-off-by: alcorj.mizar <[email protected]>

TravisBuddy · 2020-07-03T00:48:35Z

Travis tests have failed

Hey @alcorj-mizar,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: d35486a0-bcc6-11ea-ab91-9125a069a76b

add placeholder check to reduce execution time Signed-off-by: alcorj.mizar <[email protected]>

TravisBuddy · 2020-07-03T00:57:42Z

Travis tests have failed

Hey @alcorj-mizar,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 312cc480-bcc8-11ea-ab91-9125a069a76b

move cases to reclaim.go and add lackof resources group Signed-off-by: alcorj.mizar <[email protected]>

hzxuzhonghu · 2020-07-03T03:41:13Z

test/e2e/reclaim.go

+		ctx := initTestContext(options{
+			queues:             []string{q2},
+			nodesNumLimit:      4,
+			nodesResourceLimit: v1.ResourceList{"cpu": resource.MustParse("1000m"), "memory": resource.MustParse("1024Mi")},


nit: can we use oneCPU or something?

small nits fixed

hzxuzhonghu

/lgtm

TravisBuddy · 2020-07-03T04:14:37Z

Travis tests have failed

Hey @alcorj-mizar,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: b34345f0-bce3-11ea-ab91-9125a069a76b

fix nits of resource definition Signed-off-by: alcorj.mizar <[email protected]>

TravisBuddy · 2020-07-03T06:01:50Z

Travis tests have failed

Hey @alcorj-mizar,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: adb92140-bcf2-11ea-ab91-9125a069a76b

hzxuzhonghu

/lgtm
/approve

Some nits to be fixed, i would approve not to block other prs

hzxuzhonghu · 2020-07-03T06:14:31Z

test/e2e/util.go

+func setPlaceHolderForSchedulerTesting(ctx *testContext, req v1.ResourceList, reqNum int) (bool, error) {
+
+	if !satisifyMinNodesRequirements(ctx, reqNum) {
+		return false, lagencyerror.New("Failed to setup environment, you need to have at least " + strconv.Itoa(len(req)) + " worker node.")


nit: fmt.Errorf

hzxuzhonghu · 2020-07-03T06:21:00Z

test/e2e/util.go

+}
+
+func deletePlaceHolder(ctx *testContext) {
+	podList, err := ctx.kubeclient.CoreV1().Pods("default").List(context.TODO(), metav1.ListOptions{})


nit: s/"default"/ctx.Namespace/

same applies to create place holder

hzxuzhonghu · 2020-07-03T06:22:28Z

test/e2e/util.go

+	podList, err := ctx.kubeclient.CoreV1().Pods("default").List(context.TODO(), metav1.ListOptions{})
+	Expect(err).NotTo(HaveOccurred())
+	for _, pod := range podList.Items {
+		if pod.Labels["role"] == "placeholder" {


This is not efficient loop all the pods, you can use field LabelSelector instead

hzxuzhonghu · 2020-07-03T06:25:37Z

test/e2e/reclaim.go

+		ctx := initTestContext(options{
+			queues:             []string{q2},
+			nodesNumLimit:      4,
+			nodesResourceLimit: CPU1Mem1,


nit: How could you know how much resource and how many nodes to occupy?

According to test cases, and there is a node num check in init processes, the check will tell user to skip some cases that they can not afford.

TravisBuddy · 2020-07-03T06:50:14Z

Travis tests have failed

Hey @alcorj-mizar,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 70a34bd0-bcf9-11ea-ab91-9125a069a76b

remove no passing cases Signed-off-by: alcorj.mizar <[email protected]>

hzxuzhonghu

/lgtm

Please fix the left comments later

volcano-sh-bot · 2020-07-03T08:34:49Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: alcorj-mizar, hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

e2e: create placeholder support for e2e cases and add reclaim cases

8d93ba2

1. create placeholder when e2e need different flavor of nodes 2. add reclaim cases when new job comes in Signed-off-by: alcorj.mizar <[email protected]>

volcano-sh-bot requested review from k82cn and kevin-wangzefeng July 2, 2020 08:36

volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 2, 2020

alcorj-mizar force-pushed the master branch 2 times, most recently from d3003a9 to 9a91c8f Compare July 2, 2020 09:05

alcorj-mizar force-pushed the master branch from 9a91c8f to e9fe82f Compare July 2, 2020 10:03

alcorj-mizar force-pushed the master branch 3 times, most recently from d03c67a to 7811052 Compare July 2, 2020 14:24

alcorj-mizar force-pushed the master branch from 7811052 to 0d12a62 Compare July 2, 2020 14:31

alcorj-mizar force-pushed the master branch 2 times, most recently from 1fbab60 to ff65797 Compare July 3, 2020 00:09

e2e: update slot resource

8b87301

update slot resources Signed-off-by: alcorj.mizar <[email protected]>

alcorj-mizar force-pushed the master branch from ff65797 to 8b87301 Compare July 3, 2020 00:09

e2e: add placeholder check to reduce execution time

442a673

add placeholder check to reduce execution time Signed-off-by: alcorj.mizar <[email protected]>

alcorj-mizar force-pushed the master branch from b19755b to 442a673 Compare July 3, 2020 00:54

e2e: move cases to reclaim.go and add lackof resources group

2284a36

move cases to reclaim.go and add lackof resources group Signed-off-by: alcorj.mizar <[email protected]>

hzxuzhonghu reviewed Jul 3, 2020

View reviewed changes

volcano-sh-bot assigned hzxuzhonghu Jul 3, 2020

volcano-sh-bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 3, 2020

alcorj-mizar force-pushed the master branch from eab4843 to e959722 Compare July 3, 2020 05:13

e2e: fix nits of resource definition

7237e33

fix nits of resource definition Signed-off-by: alcorj.mizar <[email protected]>

alcorj-mizar force-pushed the master branch from e959722 to 7237e33 Compare July 3, 2020 06:01

hzxuzhonghu reviewed Jul 3, 2020

View reviewed changes

volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2020

hzxuzhonghu added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2020

alcorj-mizar force-pushed the master branch from 7237e33 to 2284a36 Compare July 3, 2020 06:44

volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2020

e2e: remove no passing cases

6bb1788

remove no passing cases Signed-off-by: alcorj.mizar <[email protected]>

hzxuzhonghu approved these changes Jul 3, 2020

View reviewed changes

volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2020

volcano-sh-bot merged commit 5071fc0 into volcano-sh:master Jul 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add placeholder support for e2e and some reclaim cases #898

Add placeholder support for e2e and some reclaim cases #898

alcorj-mizar commented Jul 2, 2020

TravisBuddy commented Jul 2, 2020

TravisBuddy commented Jul 2, 2020

TravisBuddy commented Jul 2, 2020

TravisBuddy commented Jul 2, 2020

TravisBuddy commented Jul 2, 2020

TravisBuddy commented Jul 3, 2020

TravisBuddy commented Jul 3, 2020

hzxuzhonghu Jul 3, 2020

alcorj-mizar Jul 3, 2020

hzxuzhonghu left a comment

TravisBuddy commented Jul 3, 2020

TravisBuddy commented Jul 3, 2020

hzxuzhonghu left a comment

hzxuzhonghu Jul 3, 2020

hzxuzhonghu Jul 3, 2020

hzxuzhonghu Jul 3, 2020

alcorj-mizar Jul 3, 2020

hzxuzhonghu Jul 3, 2020

alcorj-mizar Jul 3, 2020

TravisBuddy commented Jul 3, 2020

hzxuzhonghu left a comment

volcano-sh-bot commented Jul 3, 2020

Add placeholder support for e2e and some reclaim cases #898

Add placeholder support for e2e and some reclaim cases #898

Conversation

alcorj-mizar commented Jul 2, 2020

TravisBuddy commented Jul 2, 2020

Travis tests have failed

TravisBuddy Request Identifier: 382c4b90-bc3f-11ea-937a-75d40a178b7c

TravisBuddy commented Jul 2, 2020

Travis tests have failed

TravisBuddy Request Identifier: f4c4e3c0-bc49-11ea-937a-75d40a178b7c

TravisBuddy commented Jul 2, 2020

Travis tests have failed

TravisBuddy Request Identifier: 197416c0-bc52-11ea-937a-75d40a178b7c

TravisBuddy commented Jul 2, 2020

Travis tests have failed

TravisBuddy Request Identifier: e66a9d80-bc6f-11ea-937a-75d40a178b7c

TravisBuddy commented Jul 2, 2020

Travis tests have failed

TravisBuddy Request Identifier: bce51000-bc77-11ea-937a-75d40a178b7c

TravisBuddy commented Jul 3, 2020

Travis tests have failed

TravisBuddy Request Identifier: d35486a0-bcc6-11ea-ab91-9125a069a76b

TravisBuddy commented Jul 3, 2020

Travis tests have failed

TravisBuddy Request Identifier: 312cc480-bcc8-11ea-ab91-9125a069a76b

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hzxuzhonghu left a comment

Choose a reason for hiding this comment

TravisBuddy commented Jul 3, 2020

Travis tests have failed

TravisBuddy Request Identifier: b34345f0-bce3-11ea-ab91-9125a069a76b

TravisBuddy commented Jul 3, 2020

Travis tests have failed

TravisBuddy Request Identifier: adb92140-bcf2-11ea-ab91-9125a069a76b

hzxuzhonghu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TravisBuddy commented Jul 3, 2020

Travis tests have failed

TravisBuddy Request Identifier: 70a34bd0-bcf9-11ea-ab91-9125a069a76b

hzxuzhonghu left a comment

Choose a reason for hiding this comment

volcano-sh-bot commented Jul 3, 2020