Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set DNSPolicy=ClusterFirstWithHostNet when hostnetwork set #779

Merged
merged 2 commits into from
Apr 20, 2020
Merged

Set DNSPolicy=ClusterFirstWithHostNet when hostnetwork set #779

merged 2 commits into from
Apr 20, 2020

Conversation

hzxuzhonghu
Copy link
Collaborator

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 18, 2020
k82cn
k82cn reviewed Apr 18, 2020
View reviewed changes
pkg/controllers/job/job_controller_util.go Outdated
@@ -57,6 +57,10 @@ func createJobPod(job *batch.Job, template *v1.PodTemplateSpec, ix int) *v1.Pod
if len(pod.Spec.SchedulerName) == 0 {
pod.Spec.SchedulerName = job.Spec.SchedulerName
}
// If dns policy not set when hostNetwork=true, set it to `ClusterFirstWithHostNet`
if pod.Spec.HostNetwork == true && pod.Spec.DNSPolicy == "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add this into admission controller?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, anyway makes sense to me

k82cn
k82cn reviewed Apr 18, 2020
View reviewed changes
pkg/controllers/job/job_controller_util.go Outdated
@@ -57,6 +57,10 @@ func createJobPod(job *batch.Job, template *v1.PodTemplateSpec, ix int) *v1.Pod
if len(pod.Spec.SchedulerName) == 0 {
pod.Spec.SchedulerName = job.Spec.SchedulerName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto, admission controller.

@k82cn
Copy link
Member

k82cn commented Apr 18, 2020

/approve

guunergooner
guunergooner reviewed Apr 20, 2020
View reviewed changes
pkg/controllers/job/job_controller_util.go Outdated
@@ -57,6 +57,10 @@ func createJobPod(job *batch.Job, template *v1.PodTemplateSpec, ix int) *v1.Pod
if len(pod.Spec.SchedulerName) == 0 {
pod.Spec.SchedulerName = job.Spec.SchedulerName
}
// If dns policy not set when hostNetwork=true, set it to `ClusterFirstWithHostNet`
if pod.Spec.HostNetwork == true && pod.Spec.DNSPolicy == "" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest the following syntax ？

  if pod.Spec.HostNetwork && len(pod.Spec.DNSPolicy) == 0 {

Copy link
Collaborator Author

@hzxuzhonghu hzxuzhonghu Apr 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i must be drunk at that time

@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 20, 2020
@k82cn
Copy link
Member

k82cn commented Apr 20, 2020

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2020
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit 28c04aa into volcano-sh:master Apr 20, 2020
k82cn
k82cn reviewed Apr 20, 2020
View reviewed changes
pkg/webhooks/admission/jobs/mutate/mutate_job.go
DefaultQueue = "default"

defaultSchedulerName = "volcano"
Copy link
Member

@k82cn k82cn Apr 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this as an argument/parameter of admission, similar to DefaultQueue.

@k82cn k82cn mentioned this pull request May 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guunergooner guunergooner guunergooner left review comments

@k82cn k82cn k82cn left review comments

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hzxuzhonghu @k82cn @volcano-sh-bot @guunergooner