Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Docker installation #87

Open
jtpio opened this issue Jun 26, 2020 · 0 comments
Open

Update the Docker installation #87

jtpio opened this issue Jun 26, 2020 · 0 comments

Comments

@jtpio
Copy link
Member

jtpio commented Jun 26, 2020

We currently install docker using the tljh_extra_apt_packages hook:

@hookimpl
def tljh_extra_apt_packages():
return [
'docker.io'
]

However the Docker documentation recommends uninstalling docker.io and use a different procedure instead:

https://docs.docker.com/engine/install/ubuntu/

We could then add the steps to install docker-ce in the tljh_post_install hook instead:

@hookimpl
def tljh_post_install():
ensure_builder_units()

By executing apt commands directly, similar to what is done in TLJH:

https://github.com/jupyterhub/the-littlest-jupyterhub/blob/bdaab082ea1171b65a30bd93e27db4fc9b694a44/bootstrap/bootstrap.py#L127-L129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant