Add product develop document #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herrbenesch
commented
Aug 26, 2024
gwassing
reviewed
Aug 26, 2024
amureki
reviewed
Aug 28, 2024
|
@karlawithakey every dev left their comments. Let me know how you'd want to proceed here. |
|
Thanks everyone, I will address your comments. |
gwassing
reviewed
Sep 3, 2024
codingjoe
approved these changes
Sep 3, 2024
mostafa-anm
approved these changes
Sep 5, 2024
Co-authored-by: mostafa-anm <[email protected]>
codingjoe
reviewed
Sep 5, 2024
codingjoe
approved these changes
Sep 5, 2024
codingjoe
reviewed
Sep 5, 2024
There was a problem hiding this comment.
@karlawithakey we went through everything together in the engineering team meeting. I'd love your final thoughts on this.
product_development.md
Outdated
Comment on lines
27
to
31
| ### New feature tickets | ||
|
|
||
| New features are the result of analysis or research based user demand. | ||
| The product and design teams own the requirements engineering and conception of new features. | ||
| They are responsible for creating tickets that are ready to be pulled into the backlog. |
There was a problem hiding this comment.
We were unsure. Isn't a new feature always a growth opportunity? I wonder if they need more distinction or should simply be merged.
Comment on lines
+123
to
+125
| ### Development Kick-Off | ||
|
|
||
| To prevent ticket ping pong, a kick-off is an optional short meeting, that can be scheduled by an engineer when they pick up new work. Its discussion should be reflected in the ticket. We aim for great tickets, but sometimes we miss. |
There was a problem hiding this comment.
This is new @karlawithakey, I'd love to get your opinion.
amureki
reviewed
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.