Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot move to ES2020 when using TS 4.3.2 #46

Open
marcvelmer opened this issue Jun 22, 2021 · 0 comments
Open

Cannot move to ES2020 when using TS 4.3.2 #46

marcvelmer opened this issue Jun 22, 2021 · 0 comments

Comments

@marcvelmer
Copy link
Collaborator

For some (weird?) reason, there is a problem when using ES2020 as target in the TS config.

{
    "compilerOptions": {
        "module": "commonjs",
        "moduleResolution": "node",
        "resolveJsonModule": true,
        "pretty": true,
        "declaration": true,
        "sourceMap": true,
        "target": "es2020", <- FAILS!
        "outDir": "dist",
        "baseUrl": "src"
    },
    "include": [
        "src/**/*.ts"
    ],
    "exclude": [
        "node_modules",
        "src/protobuf/src",
        "src/protobuf/build/dart",
        "src/protobuf/build/go"
    ]
}

This is blocking because otherwise we cannot use Promise.allSettled() and it's needed for the new discovery process to work properly. I have bypassed the problem by targeting ES6 again, but it's something we need to review.

The error thrown can be seen here: https://github.com/vocdoni/dvote-js/runs/2885662878?check_suite_focus=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant