Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCH Creation API: Decide what to do if RoutingDestinations is empty #6715

Closed
zjs opened this issue Nov 8, 2017 · 3 comments
Closed

VCH Creation API: Decide what to do if RoutingDestinations is empty #6715

zjs opened this issue Nov 8, 2017 · 3 comments
Assignees
Labels
area/api The Vritual Container Host management API component/install kind/debt Problems that increase the cost of other work team/lifecycle

Comments

@zjs
Copy link
Member

zjs commented Nov 8, 2017

Currently, the fromGateway method used by the VCH creation API handlers is unclear about the behavior if the supplied RoutingDestinations are empty. We should determine what work, if any, is required here.

@zjs zjs added area/api The Vritual Container Host management API component/install kind/debt Problems that increase the cost of other work team/lifecycle labels Nov 8, 2017
@zjs zjs added this to the Sprint 21 Lifecycle milestone Nov 8, 2017
@andrewtchin
Copy link
Contributor

determine when routingdestinations is required (should match cli) and figure out if we can use swagger features for validation

@andrewtchin
Copy link
Contributor

Related #6400

@zjs
Copy link
Member Author

zjs commented Nov 9, 2017

Relevant lines from the vic-machine-* CLI help output:

   --client-network-gateway value                   Gateway for the VCH on the client network, including one or more routing destinations in a comma separated list, e.g. 10.1.0.0/16,10.2.0.0/16:10.0.0.1
   --public-network-gateway value                   Gateway for the VCH on the public network, e.g. 10.0.0.1
   --management-network-gateway value               Gateway for the VCH on the management network, including one or more routing destinations in a comma separated list, e.g. 10.1.0.0/16,10.2.0.0/16:10.0.0.1
   --container-network-gateway value, --cng value   Gateway for the container network's subnet in CONTAINER-NETWORK:SUBNET format, e.g. vsphere-net:172.16.0.1/16

Based on this, it would appear that the CLI's requirements differ slightly depending on the type of network:

  • Client: one or more
  • Public: zero
  • Management: one or more
  • Container: exactly one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api The Vritual Container Host management API component/install kind/debt Problems that increase the cost of other work team/lifecycle
Projects
None yet
Development

No branches or pull requests

2 participants