Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pull by image digest #1186

Closed
cgtexmex opened this issue Jun 23, 2016 · 3 comments
Closed

Support pull by image digest #1186

cgtexmex opened this issue Jun 23, 2016 · 3 comments
Assignees
Labels
area/docker Support for the Docker operations component/imagec kind/defect Behavior that is inconsistent with what's intended kind/enhancement Behavior that was intended, but we want to make better priority/p2
Milestone

Comments

@cgtexmex
Copy link
Contributor

cgtexmex commented Jun 23, 2016

Currently imagec is only able to pull images by tag. For example:

docker pull busybox:1.24.2

We need to provide support for pulling images via image digest:

docker pull busybox@sha256:4a731fb46adc5cefe3ae374a8b6020fc1b6ad667a279647766e9a3cd89f6fa92

While vic (via imagec) will attempt a pull when a user provides a digest, it's not pulling via the digest -- it's actually pulling via the latest tag. Since the digest is ignored the wrong image might be pulled.

Depends on #1484

@cgtexmex cgtexmex added kind/enhancement Behavior that was intended, but we want to make better area/docker Support for the Docker operations component/imagec labels Jun 23, 2016
@cgtexmex cgtexmex changed the title Support pull by digest Support pull by image digest Jun 23, 2016
@hickeng hickeng added the impact/doc/user Requires changes to official user documentation label Jun 25, 2016
@mdubya66 mdubya66 added this to the VIC GA Release milestone Jun 29, 2016
@stuclem stuclem removed the impact/doc/user Requires changes to official user documentation label Jul 13, 2016
@mdubya66 mdubya66 removed this from the VIC GA Release milestone Oct 3, 2016
@jzt jzt removed their assignment Jan 17, 2017
@hickeng
Copy link
Member

hickeng commented Apr 27, 2017

Needed to support even client side notary use.

@cgtexmex
Copy link
Contributor Author

cgtexmex commented Apr 28, 2017

Here's an example of pulling the wrong image:

docker pull nginx@sha256:ebd2b85803e78100a582385f7eac56cd367561f0f2bab005f784cda95818d41f
Pulling from library/nginx
36a46ebd5019: Pull complete
a3ed95caeb02: Pull complete
57168433389f: Pull complete
332ec8285c50: Pull complete
Digest: sha256:c15f1fb8fd55c60c72f940a76da76a5fccce2fefa0dd9b17967b9e40b0355316
Status: Downloaded newer image for library/nginx:latest

Notice the sha256 that's requested is ebd2b85803e78100a582385f7eac56cd367561f0f2bab005f784cda95818d41f, but what is actually returned is c15f1fb8fd55c60c72f940a76da76a5fccce2fefa0dd9b17967b9e40b0355316. The returned image is the current latest image.

From my perspective this should move up in priority since it's not only wrong, but masks the issue and gives the illusion of working.

@hickeng hickeng added kind/defect Behavior that is inconsistent with what's intended priority/p2 and removed priority/p4 labels Apr 28, 2017
@hickeng
Copy link
Member

hickeng commented Apr 28, 2017

adjusting labels based on @cgtexmex comment - I had thought it was unavailable, not available but incorrect; agree that this is bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docker Support for the Docker operations component/imagec kind/defect Behavior that is inconsistent with what's intended kind/enhancement Behavior that was intended, but we want to make better priority/p2
Projects
None yet
Development

No branches or pull requests

6 participants