Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the different debug levels #68

Closed
stuclem opened this issue Mar 22, 2017 · 19 comments
Closed

Document the different debug levels #68

stuclem opened this issue Mar 22, 2017 · 19 comments
Assignees
Labels
area/pub/vsphere Published documentation for vSphere administrators area/pub Published documentation for end-users product/engine Related to the vSphere Integrated Containers Engine

Comments

@stuclem
Copy link
Contributor

stuclem commented Mar 22, 2017

From @stuclem on May 30, 2016 15:14

Per vmware/vic#709.

Copied from original issue: vmware/vic#852

@stuclem stuclem self-assigned this Mar 22, 2017
@stuclem
Copy link
Contributor Author

stuclem commented Mar 22, 2017

vmware/vic#709 is in GA release.

@stuclem stuclem added the area/pub Published documentation for end-users label Mar 22, 2017
@stuclem
Copy link
Contributor Author

stuclem commented Mar 22, 2017

When implemented, will require an update to the existing section on --debug in the topic on vic-machine create options, and a section in Admin about how to access and understand the information.

@stuclem
Copy link
Contributor Author

stuclem commented Mar 22, 2017

vmware/vic#709 is implemented in PRs vmware/vic#1216 and vmware/vic#1217.

@stuclem
Copy link
Contributor Author

stuclem commented Mar 22, 2017

According to Faiyaz, vmware/vic#1216 is internal.

@stuclem
Copy link
Contributor Author

stuclem commented Mar 22, 2017

According to @hickeng in https://communities.vmware.com/message/2626719#2626719, setting debug to 3 suppresses the restart of failed components. We need to find out and document the exact effect of setting debug to 1, 2, 3 ... n. Currently we just talk about setting debug to a value >1.

@stuclem
Copy link
Contributor Author

stuclem commented Mar 22, 2017

Not required for 0.7, so moving back to backlog.

@stuclem
Copy link
Contributor Author

stuclem commented Mar 22, 2017

In vmware/vic#3081 (comment) @hickeng says that debug >2 automatically enables SSH.

@hickeng are these debug levels spec'd anywhere?

@stuclem
Copy link
Contributor Author

stuclem commented Mar 22, 2017

Added more info to https://github.com/stuclem/vic/blob/master/doc/user_doc/vic_installation/vch_installer_options.md#--debug: "For example, setting --debug to 2 or greater automatically enables SSH access to the VCH endpoint VM. Setting --debug to 3 suppresses the restart of failed components." I do feel that this is very incomplete, though. I would really like to obtain a proper list of what each logging level does.

@hickeng do you have more info about what each logging level does? I have a snippet for 2 and 3, but what about 4, 5, ... n? How high can n be?

@stuclem
Copy link
Contributor Author

stuclem commented Mar 22, 2017

Nice to have for 1.1, but might not make the cut.

@stuclem stuclem added the product/engine Related to the vSphere Integrated Containers Engine label Mar 22, 2017
@stuclem stuclem added this to the Doc for 1.1 milestone Mar 22, 2017
@stuclem stuclem removed their assignment Mar 22, 2017
@stuclem
Copy link
Contributor Author

stuclem commented Apr 4, 2017

Still no info about this. Moving out of 1.1.

@stuclem stuclem removed this from the Doc for 1.1 milestone Apr 4, 2017
@hickeng
Copy link
Member

hickeng commented Apr 5, 2017

@stuclem Not spec'd as such - I've opened vmware/vic#4575 to do a better job of this. But the basics are:

1: extra verbosity, no changes to behaviour
2: changes to behaviour - exposes servers on more interfaces, launches pprof in containerVMs
3: disable recovery logic, log sensitive data - disables component restart in appliance, and containerVM shutdown. Logs environment and details for user application, and collects application output in log bundle.

@stuclem
Copy link
Contributor Author

stuclem commented Apr 5, 2017

Great, thanks @hickeng!

@stuclem stuclem added this to the Doc for 1.1 milestone Apr 5, 2017
@stuclem
Copy link
Contributor Author

stuclem commented Apr 14, 2017

Added the info from the comment above to the description of the vic-machine create --debug option.

Change is in stuclem@3ab8c2b. @hickeng is this OK? Thanks!

@stuclem stuclem modified the milestones: Doc for 1.1 refresh, Doc for 1.1 Apr 18, 2017
@stuclem
Copy link
Contributor Author

stuclem commented Apr 18, 2017

Changes merged in #158, but leaving this open for final verification by @hickeng.

@hickeng
Copy link
Member

hickeng commented May 1, 2017

@stuclem We're going to vet the code where the debug levels are used to confirm current behaviour - what I described was original intent but unverified.
There's an issue open (vmware/vic#4575) for a more structured and enforced approach.

I presume you just need current behaviour for this - what level of detail?

@stuclem
Copy link
Contributor Author

stuclem commented May 2, 2017

@hickeng yes, we need the behaviour as it is in 1.1. I don't think that we need masses of detail - just enough to let people know why they might need or want to set a level higher than 1, and what impact that will have on their setup. Thanks!

@stuclem
Copy link
Contributor Author

stuclem commented May 18, 2017

This change is merged, but leaving this issue open pending the code vetting by @hickeng.

@stuclem stuclem removed this from the Doc refresh for 1.1.1 milestone May 18, 2017
@stuclem stuclem added this to the Doc for 1.2 milestone Jun 12, 2017
@stuclem
Copy link
Contributor Author

stuclem commented Jun 12, 2017

To be verified in 1.2.

@stuclem stuclem self-assigned this Jun 12, 2017
@stuclem stuclem added the area/pub/vsphere Published documentation for vSphere administrators label Jun 13, 2017
@stuclem
Copy link
Contributor Author

stuclem commented Aug 10, 2017

Given @chengwang86 's comments in #532, I think that it's safe to finally close this one.

@stuclem stuclem closed this as completed Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/pub/vsphere Published documentation for vSphere administrators area/pub Published documentation for end-users product/engine Related to the vSphere Integrated Containers Engine
Projects
None yet
Development

No branches or pull requests

2 participants