Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SCSI controller and unit number support, attach disks on build #542

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ZsoltFejes
Copy link

@ZsoltFejes ZsoltFejes commented Nov 18, 2024

Closes #538

@ZsoltFejes ZsoltFejes marked this pull request as ready for review November 18, 2024 10:57
@ZsoltFejes
Copy link
Author

Tests I carried out

  • One disk with valid controller and unit, and attach before boot set to true - Disk is attached during build correctly to the specified controller and unit
  • One disk with correct controller and unit, and attach before boot set to true - Disk was attached to the correct controller and unit after the VM was built
  • One disk with correct controller but no unit - Default Aria automation behaviour, attached disk to the root disk’s controller and the next available unit
  • One disk with missing controller specified but unit is specified - Default aria behaviour, attached disk to the root disk’s controller and the next available unit
  • Two disks with the same controller and unit - Aria failed to attach the second disk, returned error stating unable to attach controller and unit number is already attached
  • Two disks, one disk was specified with controller and unit number the second disk wasn’t - Disk with specified placement was correct, the one without placement was attached to the controller of the root disk to the next available unit

@tenthirtyam tenthirtyam requested a review from frodenas November 19, 2024 13:28
@tenthirtyam tenthirtyam added the enhancement Enhancement label Nov 19, 2024
@tenthirtyam tenthirtyam linked an issue Nov 19, 2024 that may be closed by this pull request
1 task
vra/resource_machine.go Outdated Show resolved Hide resolved
vra/resource_machine.go Outdated Show resolved Hide resolved
vra/resource_machine.go Outdated Show resolved Hide resolved
vra/resource_machine.go Outdated Show resolved Hide resolved
@vmwclabot
Copy link
Member

@ZsoltFejes, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Dec 3, 2024
@vmwclabot
Copy link
Member

@ZsoltFejes, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@github-actions github-actions bot added documentation Documentation provider Provider needs-review Needs Review labels Dec 3, 2024
@vmwclabot
Copy link
Member

@ZsoltFejes, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@ZsoltFejes, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@ZsoltFejes, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@ZsoltFejes, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@ZsoltFejes, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

vra/resource_machine.go Outdated Show resolved Hide resolved
@tenthirtyam tenthirtyam changed the title feature: SCSI controller and unit number support, attach disks on build feat: SCSI controller and unit number support, attach disks on build Dec 3, 2024
@vmwclabot
Copy link
Member

@ZsoltFejes, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-required DCO Required documentation Documentation enhancement Enhancement needs-review Needs Review provider Provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

diskAttachmentProperties for disk attachment to a VM not exposed
3 participants