Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only allow specifying an image and tag or an image digest #519

Closed
nishakm opened this issue Jan 10, 2020 · 1 comment · Fixed by #533
Closed

Only allow specifying an image and tag or an image digest #519

nishakm opened this issue Jan 10, 2020 · 1 comment · Fixed by #533
Milestone
Release 2.0.0

Comments

@nishakm
Copy link
Contributor

nishakm commented Jan 10, 2020

Describe the bug
Deferring to the Python API to figure out what image to download can result in some non-deterministic action. See #510 as an example where providing an image with no tag downloads "latest" and all other available tags.

Expected behavior

  1. The user should provide an image name of the type image:tag
  2. The user should provide an image name of the type image@digest_type:digest
  3. Any other style of image name should cause an error

Environment you are running Tern on
Enter all that apply

Tern version 1.0.2
Python version 3.6.9
Ubuntu 18.04 LTS
@nishakm nishakm mentioned this issue Jan 10, 2020
Closed
@nishakm nishakm added this to the Release 1.1.0 milestone Jan 15, 2020
@PrajwalM2212
Copy link
Contributor

I am working on this.

PrajwalM2212 added a commit to PrajwalM2212/tern that referenced this issue Feb 11, 2020
@PrajwalM2212
__main__.py: Check docker image string
ad9833e 
This PR tests that the docker image string provided to tern is of image:tag or image@digest_type:digest format

Closes tern-tools#519

Signed-off-by: PrajwalM2212 <[email protected]>
@PrajwalM2212 PrajwalM2212 mentioned this issue Feb 11, 2020
Merged
PrajwalM2212 added a commit to PrajwalM2212/tern that referenced this issue Feb 11, 2020
@PrajwalM2212
__main__.py: Check docker image string
93d3d88 
This PR tests that the docker image string
provided to tern is of image:tag
or image@digest_type:digest format

Closes tern-tools#519

Signed-off-by: PrajwalM2212 <[email protected]>
PrajwalM2212 added a commit to PrajwalM2212/tern that referenced this issue Feb 11, 2020
@PrajwalM2212
__main__.py: Check docker image string
fbd4da5 
This PR tests that the docker image string
provided to tern is of image:tag
or image@digest_type:digest format

Closes tern-tools#519

Signed-off-by: PrajwalM2212 <[email protected]>
PrajwalM2212 added a commit to PrajwalM2212/tern that referenced this issue Feb 11, 2020
@PrajwalM2212
__main__.py: Check docker image string
964729e 
This PR tests that the docker image string
provided to tern is of image:tag
or image@digest_type:digest format

Closes tern-tools#519

Signed-off-by: PrajwalM2212 <[email protected]>
PrajwalM2212 added a commit to PrajwalM2212/tern that referenced this issue Feb 11, 2020
@PrajwalM2212
__main__.py: Check docker image string
4f43cb7 
This PR tests that the docker image string
provided to tern is of image:tag
or image@digest_type:digest format

Closes tern-tools#519

Signed-off-by: PrajwalM2212 <[email protected]>
PrajwalM2212 added a commit to PrajwalM2212/tern that referenced this issue Feb 11, 2020
@PrajwalM2212
__main__.py: Check docker image string
e62fdb6 
This PR tests that the docker image string
provided to tern is of image:tag
or image@digest_type:digest format

Closes tern-tools#519

Signed-off-by: PrajwalM2212 <[email protected]>
nishakm pushed a commit that referenced this issue Feb 11, 2020
@PrajwalM2212
__main__.py: Check docker image string
d18c4e1 
This PR tests that the docker image string
provided to tern is of image:tag
or image@digest_type:digest format

Closes #519

Signed-off-by: PrajwalM2212 <[email protected]>
rnjudge pushed a commit to rnjudge/tern that referenced this issue Jun 5, 2020
@PrajwalM2212
__main__.py: Check docker image string
f12f609 
This PR tests that the docker image string
provided to tern is of image:tag
or image@digest_type:digest format

Closes tern-tools#519

Signed-off-by: PrajwalM2212 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.0.0
Development

Successfully merging a pull request may close this issue.

__main__.py: Check docker image string PrajwalM2212/tern
2 participants
@nishakm @PrajwalM2212