Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT and BUG] Non-blocking getSupportedLocales when fetching messages #877

Closed
jessiejuachon opened this issue Nov 17, 2020 · 1 comment · Fixed by #878
Closed
Assignees
Labels
area/java-client kind/bug Something isn't working kind/feature New feature or request priority/high
Milestone

Comments

@jessiejuachon
Copy link
Contributor

jessiejuachon commented Nov 17, 2020

Is your feature request related to a problem? Please describe.
There are 2 issues:

  1. Message fetch fails if getSupportedLocales failed, even if messages are available in remote/local dataSource.
    This should not be the case because getting the list of supported locales is only primarily used for caching and performance.
  2. Message fetch is delayed if supported locales hasn't been cached.

Describe the solution you'd like
Even if getSupportedLocales had failed (e.g. VIP service was temporarily down), message fetch should not be blocked.
Even if the set of supported locales is not yet in cache (e.g. supported locales cache is not initialized (i.e initializeCache=false)), message fetch should not have to wait. getSupportedLocales should be done in a separate concurrent thread.

@jessiejuachon jessiejuachon added this to the Sprint 92 milestone Nov 17, 2020
@jessiejuachon jessiejuachon self-assigned this Nov 17, 2020
@jessiejuachon jessiejuachon added the kind/bug Something isn't working label Nov 17, 2020
@jessiejuachon jessiejuachon changed the title [ENHANCEMENT] Non-blocking getSupportedLocales for caching [ENHANCEMENT and BUG] Non-blocking getSupportedLocales for caching Nov 17, 2020
@jessiejuachon jessiejuachon changed the title [ENHANCEMENT and BUG] Non-blocking getSupportedLocales for caching [ENHANCEMENT and BUG] Non-blocking getSupportedLocales when caching Nov 17, 2020
@jessiejuachon jessiejuachon changed the title [ENHANCEMENT and BUG] Non-blocking getSupportedLocales when caching [ENHANCEMENT and BUG] Non-blocking getSupportedLocales when fetching messages Nov 17, 2020
@lyiyu66
Copy link

lyiyu66 commented Dec 22, 2020

The issue and specific Windows issue have been fixed with commit 3678872.

@lyiyu66 lyiyu66 closed this as completed Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/java-client kind/bug Something isn't working kind/feature New feature or request priority/high
Projects
None yet
2 participants