Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect typing in PortConnection #1056

Closed
IvarVirusiim opened this issue Nov 20, 2023 · 1 comment
Closed

Incorrect typing in PortConnection #1056

IvarVirusiim opened this issue Nov 20, 2023 · 1 comment
Labels
bug

Comments

@IvarVirusiim
Copy link

IvarVirusiim commented Nov 20, 2023 •
edited
Loading

Describe the bug

According to the documentation, the fields in dvs\__init__.pyi PortConnection should be optional (except switchUuid).

https://vdc-repo.vmware.com/vmwb-repository/dcr-public/184bb3ba-6fa8-4574-a767-d0c96e2a38f4/ba9422ef-405c-47dd-8553-e11b619185b2/SDK/vsphere-ws/docs/ReferenceGuide/vim.dvs.PortConnection.html

Reproduction steps

from pyVmomi import vim
port_connection = vim.dvs.PortConnection()
port_connection.portKey = None

Run mypy and get Incompatible types in assignment

Expected behavior

None should be an accepted value.

Additional context

No response
@karaatanassov karaatanassov mentioned this issue Dec 29, 2023
Open
@karaatanassov
Copy link

Duplicate of #1048

@karaatanassov karaatanassov marked this as a duplicate of #1048 Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karaatanassov @IvarVirusiim