From 6cdecccf4ebf645ec704bd3726cffa53db2f6c57 Mon Sep 17 00:00:00 2001 From: George Hicken Date: Fri, 14 Jul 2023 05:57:18 -0700 Subject: [PATCH] vcsim: add interactive debug github action stage Adds a stage to the github actions pipeline that provides an ssh server that allows interactive login to the environment. This only triggers on failure. The reason for adding this is due to repeated failures to find functional arguements for the specific docker version present. Quirks around the format parameter values specifically. This is done using the tmate action: https://github.com/mxschmitt/action-tmate Corrects boilerplate --- .github/workflows/govmomi-go-tests.yaml | 3 +++ .github/workflows/govmomi-govc-tests.yaml | 4 ++++ simulator/container_host_system.go | 4 ++-- simulator/container_host_system_test.go | 4 ++-- simulator/container_virtual_machine.go | 4 ++-- simulator/container_virtual_machine_test.go | 4 ++-- 6 files changed, 15 insertions(+), 8 deletions(-) diff --git a/.github/workflows/govmomi-go-tests.yaml b/.github/workflows/govmomi-go-tests.yaml index 3275f231b..43f07871a 100644 --- a/.github/workflows/govmomi-go-tests.yaml +++ b/.github/workflows/govmomi-go-tests.yaml @@ -60,3 +60,6 @@ jobs: TEST_TIMEOUT: 5m TEST_OPTS: "" run: make go-test + - name: Debug with tmate on failure + if: ${{ failure() }} + uses: mxschmitt/action-tmate@v3 diff --git a/.github/workflows/govmomi-govc-tests.yaml b/.github/workflows/govmomi-govc-tests.yaml index e546f5d6f..c1f587cff 100644 --- a/.github/workflows/govmomi-govc-tests.yaml +++ b/.github/workflows/govmomi-govc-tests.yaml @@ -65,6 +65,10 @@ jobs: run: | make ${{ matrix.cmd }} + - name: Debug with tmate on failure + if: ${{ failure() }} + uses: mxschmitt/action-tmate@v3 + govc-docs: name: Verify govc docs are up2date strategy: diff --git a/simulator/container_host_system.go b/simulator/container_host_system.go index 41d4fd9a6..f84f3d840 100644 --- a/simulator/container_host_system.go +++ b/simulator/container_host_system.go @@ -1,11 +1,11 @@ /* -Copyright (c) 2017 VMware, Inc. All Rights Reserved. +Copyright (c) 2023-2023 VMware, Inc. All Rights Reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 +http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/simulator/container_host_system_test.go b/simulator/container_host_system_test.go index 8709b4bc7..1233bc97b 100644 --- a/simulator/container_host_system_test.go +++ b/simulator/container_host_system_test.go @@ -1,11 +1,11 @@ /* -Copyright (c) 2019 VMware, Inc. All Rights Reserved. +Copyright (c) 2023-2023 VMware, Inc. All Rights Reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 +http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/simulator/container_virtual_machine.go b/simulator/container_virtual_machine.go index d790ac0c1..a2b91fd86 100644 --- a/simulator/container_virtual_machine.go +++ b/simulator/container_virtual_machine.go @@ -1,11 +1,11 @@ /* -Copyright (c) 2018 VMware, Inc. All Rights Reserved. +Copyright (c) 2023-2023 VMware, Inc. All Rights Reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 +http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, diff --git a/simulator/container_virtual_machine_test.go b/simulator/container_virtual_machine_test.go index e36782a66..af7419a77 100644 --- a/simulator/container_virtual_machine_test.go +++ b/simulator/container_virtual_machine_test.go @@ -1,11 +1,11 @@ /* -Copyright (c) 2023 VMware, Inc. All Rights Reserved. +Copyright (c) 2023-2023 VMware, Inc. All Rights Reserved. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at - http://www.apache.org/licenses/LICENSE-2.0 +http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS,