Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev dependencies in prod release #1157

Open
yhack opened this issue Jun 10, 2022 · 2 comments
Open

Dev dependencies in prod release #1157

yhack opened this issue Jun 10, 2022 · 2 comments

Comments

@yhack
Copy link

yhack commented Jun 10, 2022

The generated Cargo.toml files contain dependencies that don't look production ready.

#differential-dataflow = "0.11.0"
differential-dataflow = { git = "https://github.com/ddlog-dev/differential-dataflow", branch = "ddlog-4" }
#timely = "0.11"
timely = { git = "https://github.com/ddlog-dev/timely-dataflow", branch = "ddlog-4", default-features = false }

I understand this might be done during development to fix a bug or add a feature, but now the forks have fallen behind. What would it take to re-point these dependencies to official releases on crates.io?

@ryzhyk
Copy link
Contributor

ryzhyk commented Jun 11, 2022

@yhack, those aren't really dev dependencies, but slightly customized versions of timely and differential we use in DDlog. I agree we should try to keep them up to date. We aren't that far behind though, in particular I am not aware of bug fixes/significant optimizations that we're missing.

@yhack
Copy link
Author

yhack commented Jun 12, 2022

@ryzhyk, gotcha, I guess I took "dev" in the URL too literally. Taking a closer look at your slight customization, I see your comment

Ideally, we would like an adaptive channel size that scales up an down with demand.

If I'm not mistaken, something like that was implemented in master to replace the customized function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants