Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support filter the resource by name during the backup #5118

Open
ywk253100 opened this issue Jul 14, 2022 · 7 comments
Open

Support filter the resource by name during the backup #5118

ywk253100 opened this issue Jul 14, 2022 · 7 comments

Comments

@ywk253100
Copy link
Contributor

Currently, the --include-resources option of velero backup create command only supports specifying the resource type, but there are requirements that only need to back up a specified resource.

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"
@27149chen
Copy link
Contributor

  • velero restore for the same requirement

@reasonerjt
Copy link
Contributor

IMO this is a slightly lower priority than #5120
as it feels natural to use label to solve this problem?

@27149chen
Copy link
Contributor

IMO this is a slightly lower priority than #5120 as it feels natural to use label to solve this problem?

I think we should not touch user's resources, and it might cause probelms. Also labels don't work sometimes since resouces owner can revert such changes

@ywk253100
Copy link
Contributor Author

This issue #5152 describes one option about how to implement this feature

@sseago
Copy link
Collaborator

sseago commented Aug 18, 2022

@ywk253100 note that I've suggested a change to #5152 to make it more flexible with respect to includes/excludes as well as less confusing with respect to existing include/exclude behavior.

@neginhsobhani
Copy link

Currently, the --include-resources option of velero backup create command only supports specifying the resource type, but there are requirements that only need to back up a specified resource.

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here. Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"

I've deployed Velero on kubernetes cluster in corporate level and we have the same requirement. Hope they add this feature soon.

@ryankenney-dev
Copy link

+1. We are heavily invested in 3rd party helm charts and we often need to exclude resources that cannot be easily tagged (including kube-root-ca.crt). If we could just include/exclude by resource name, this remains maintainable. If not, we are forever playing whac-a-mole to tag the resources in the 3rd party resources... until the day our backups are quietly incomplete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants