Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More and more VolumeSnapshot and VolumeSnapshotContent resources are created after several times of backup/restore #4946

Open
ywk253100 opened this issue May 30, 2022 · 2 comments
Assignees
Labels
Area/CSI Related to Container Storage Interface support backlog Needs investigation

Comments

@ywk253100
Copy link
Contributor

  1. Make a backup backup1 with the CSI plugin
  2. Delete the workload and restore it from backup1
  3. Make a new backup backup2
  4. Delete the workload and restore it from backup2
  5. Repeat the steps above and find there are more and more VolumeSnapshot and VolumeSnapshotContent resources created

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"
@ywk253100 ywk253100 added the Area/CSI Related to Container Storage Interface support label May 30, 2022
@reasonerjt
Copy link
Contributor

We may skip backing up restored VS and VSC but that requires some change in the return value of backup item action plugin, which requires plugin versioning. We'll handle it post v1.9

@reasonerjt
Copy link
Contributor

Essentially what's missing is that we need to enhance the plugin so that when a backup/restore is finished we can trigger some code.

We need to investigate if this can be done when RIA v2 is introduced (will the grpc server remain running when Progress is called), or do we need a new kind of plugin.

We need to handle this post v1.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/CSI Related to Container Storage Interface support backlog Needs investigation
Projects
None yet
Development

No branches or pull requests

4 participants