Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling metadata.ManagedFields #2416

Closed
nrb opened this issue Apr 10, 2020 · 4 comments
Closed

Handling metadata.ManagedFields #2416

nrb opened this issue Apr 10, 2020 · 4 comments
Assignees
Labels
Bug Kubernetes Resources Pertains to backup/restoration of Kubernetes resources Reviewed Q2 2021
Milestone

Comments

@nrb
Copy link
Contributor

nrb commented Apr 10, 2020

kubernetes/kubernetes#72947 introduced ManagedFields into Kubernetes v1.18.

We need to determine whether or not Velero needs to do anything special with these at restore time, such as clear them off the object with the resetMetadataAndStatus function, or if they're already handled.

@dsu-igeek dsu-igeek self-assigned this Oct 21, 2020
@dsu-igeek dsu-igeek removed their assignment Oct 21, 2020
@nrb nrb self-assigned this Oct 21, 2020
@nrb nrb added Bug Kubernetes Resources Pertains to backup/restoration of Kubernetes resources and removed Needs investigation labels Oct 21, 2020
@nrb
Copy link
Contributor Author

nrb commented Oct 21, 2020

This appears to be part of server-side apply per https://kubernetes.io/blog/2020/04/01/kubernetes-1.18-feature-server-side-apply-beta-2/

Per https://kubernetes.io/docs/reference/using-api/server-side-apply/#field-management, Velero should not remove these fields and we should update resetMetadataAndStatus to reflect that. One caveat is that we may not be able to restore objects with these fields on pre-Kuberetes 1.18 clusters, but I think that may be minor as we don't technically support downgrades anyway.

Additionally, this metadata may be useful in making decisions about what to restore as opposed to using the last-applied-configuration annotation, which is subject to change.

@nrb nrb added this to the v1.6.0 milestone Oct 21, 2020
@nrb nrb changed the title Investigation: Handling ManagedFields Handling metadata.ManagedFields Oct 21, 2020
@nrb nrb removed their assignment Oct 23, 2020
@nrb nrb modified the milestones: v1.6.0, v1.7.0 Feb 3, 2021
@stale
Copy link

stale bot commented Jul 10, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the staled label Jul 10, 2021
@stale
Copy link

stale bot commented Jul 25, 2021

Closing the stale issue.

@stale stale bot closed this as completed Jul 25, 2021
@ywk253100 ywk253100 reopened this Nov 15, 2022
@stale stale bot removed the staled label Nov 15, 2022
@reasonerjt reasonerjt modified the milestones: v1.7.0, v1.11 Jan 10, 2023
@ywk253100
Copy link
Contributor

Fixed by #5853

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Kubernetes Resources Pertains to backup/restoration of Kubernetes resources Reviewed Q2 2021
Projects
None yet
Development

No branches or pull requests

5 participants