Update plugin ordering to latest Sonobuoy version #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnSchnake
reviewed
Jul 1, 2022
andrewyunt
force-pushed
the
orderedOp
branch
6 times, most recently
from
7b74436 to
bf9a98d
Compare
johnSchnake
reviewed
Jul 1, 2022
| logrus.WithField("plugin", p.GetName()).Info("Running plugin") | ||
| go aggr.RunAndMonitorPlugin(context.Background(), time.Duration(cfg.TimeoutSeconds)*time.Second, p, client, nodes.Items, cfg.AdvertiseAddress, certs[p.GetName()], aggregatorPod, progressPort, pluginResultsDir) | ||
| for _, pluginGroup := range getOrderedPlugins(plugins) { | ||
| var waitGroup sync.WaitGroup |
There was a problem hiding this comment.
👍 to using a WaitGroup. As someone new to Go I'm really happy to see you explored the options and found this. It really simplifies the logic.
johnSchnake
reviewed
Jul 1, 2022
johnSchnake
reviewed
Jul 1, 2022
andrewyunt
force-pushed
the
orderedOp
branch
4 times, most recently
from
290c212 to
fa312c1
Compare
johnSchnake
changed the title
johnSchnake
reviewed
Jul 6, 2022
johnSchnake
reviewed
Jul 6, 2022
johnSchnake
reviewed
Jul 6, 2022
johnSchnake
suggested changes
Jul 6, 2022
johnSchnake
reviewed
Jul 6, 2022
johnSchnake
suggested changes
Jul 7, 2022
Signed-off-by: Andrew Yunt <[email protected]>
|
I tried this out manually with a few cases and it worked great. Normal runs without order, worked. Edited one plugin to have order 99, launched one then the other. Modified both to have order 99, launched in parallel again. We may tweak this logic over time, but I think having this basic I already see us being able to use this and make query logic its own plugin and set its order to be high so that it gets run last. This will further simplify the core sonobuoy logic and maybe make it easier to customize too. |
johnSchnake
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Plugins should be able to run in a predetermined order. Adds order key to sonobuoy-config (lower number has a higher priority)
Which issue(s) this PR fixes