Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize access to filenames/directories in the results tarball #912

Closed
johnSchnake opened this issue Sep 27, 2019 · 3 comments
Closed
Assignees
Labels

Comments

@johnSchnake
Copy link
Contributor

So you raise a good question which I definitley touched on when coding this: who is in charge of what information and what is the right way to grab it?

A few different packages hardcode these string values (results.json, errors.json, results/, etc), some of the values here are exported, some arent. Some have methods to return their values, some dont.

I'm going to make a new ticket specifically for fixing this up and clarifying where to find all the results structure (folders/names/etc) and how to use them.

Originally posted by @johnSchnake in #909

@johnSchnake
Copy link
Contributor Author

The versioning of the tarballs is awkward and not heavily used (I saw 3 dynamic locations based on version in the file).

We might consider adding a sort of "table of contents" metafile that will just print where to find those special directories/files and then if we are reading any tarball we know where to look to find things.

Just an idea but it would prevent us from having to constantly update N branches of logic based on versioning.

@johnSchnake johnSchnake modified the milestones: v0.16.2, v0.16.3 Oct 15, 2019
@johnSchnake johnSchnake assigned johnSchnake and unassigned zubron Oct 15, 2019
@johnSchnake
Copy link
Contributor Author

Finally acknowledging this is so low priority that it just isnt happening now. Removing from milestone.

@johnSchnake johnSchnake removed this from the v0.16.3 milestone Nov 4, 2019
@johnSchnake
Copy link
Contributor Author

Closing this for now; doing some grooming on the issue list in general and closing things if either:

  • they weren't been reported by the community
  • don't have a genuine need to get done

The reason for this is that we tended to use the issue list as a backlog of very minor or wish-list type items which we wish to clear out for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants