Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update log message format #866

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

timdengyun
Copy link
Contributor

Based on golang Golang convention:
https://go.dev/wiki/CodeReviewComments#error-strings,
it should make the first letter of the log message sentence as upper case.

Based on golang Golang convention:
https://go.dev/wiki/CodeReviewComments#error-strings
it should make the first letter of the log message sentence as upper case.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.52863% with 135 lines in your changes missing coverage. Please review.

Project coverage is 70.63%. Comparing base (1aee209) to head (811a32a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
pkg/nsx/services/securitypolicy/firewall.go 13.51% 32 Missing ⚠️
cmd/main.go 0.00% 23 Missing ⚠️
pkg/nsx/cluster.go 40.90% 13 Missing ⚠️
pkg/nsx/util/utils.go 47.36% 10 Missing ⚠️
pkg/nsx/auth/jwt/vcclient.go 46.66% 8 Missing ⚠️
pkg/nsx/endpoint.go 72.72% 6 Missing ⚠️
pkg/nsx/services/securitypolicy/builder.go 0.00% 6 Missing ⚠️
pkg/controllers/securitypolicy/pod_handler.go 0.00% 4 Missing ⚠️
pkg/controllers/service/service_lb_controller.go 50.00% 4 Missing ⚠️
pkg/nsx/services/common/store.go 20.00% 4 Missing ⚠️
... and 13 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
+ Coverage   70.14%   70.63%   +0.49%     
==========================================
  Files          95       95              
  Lines       15104    15077      -27     
==========================================
+ Hits        10594    10649      +55     
+ Misses       3785     3704      -81     
+ Partials      725      724       -1     
Flag Coverage Δ
unit-tests 70.63% <40.52%> (+0.49%) ⬆️
Files with missing lines Coverage Δ
pkg/controllers/common/utils.go 77.67% <100.00%> (ø)
pkg/controllers/subnetset/subnetset_controller.go 80.20% <100.00%> (+0.20%) ⬆️
pkg/nsx/services/common/compare.go 100.00% <100.00%> (ø)
pkg/nsx/services/common/types.go 100.00% <ø> (ø)
pkg/nsx/services/subnet/builder.go 67.16% <ø> (-0.53%) ⬇️
pkg/nsx/transport.go 75.00% <100.00%> (ø)
pkg/nsx/util/license.go 100.00% <100.00%> (ø)
cmd_clean/main.go 0.00% <0.00%> (ø)
pkg/metrics/metrics.go 32.00% <0.00%> (ø)
pkg/nsx/auth/jwt/JWTtokenprovider.go 53.84% <0.00%> (ø)
... and 20 more

... and 3 files with indirect coverage changes

@zhengxiexie
Copy link
Contributor

/e2e

@timdengyun timdengyun merged commit 2b6d1b7 into vmware-tanzu:main Nov 5, 2024
3 checks passed
timdengyun added a commit to timdengyun/nsx-operator-1 that referenced this pull request Nov 5, 2024
Based on golang Golang convention:
https://go.dev/wiki/CodeReviewComments#error-strings
it should make the first letter of the log message sentence as upper case.
timdengyun added a commit that referenced this pull request Nov 5, 2024
Based on golang Golang convention:
https://go.dev/wiki/CodeReviewComments#error-strings
it should make the first letter of the log message sentence as upper case.
wenqiq pushed a commit to wenqiq/nsx-operator that referenced this pull request Nov 5, 2024
Based on golang Golang convention:
https://go.dev/wiki/CodeReviewComments#error-strings
it should make the first letter of the log message sentence as upper case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants