-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update log message format #866
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on golang Golang convention: https://go.dev/wiki/CodeReviewComments#error-strings it should make the first letter of the log message sentence as upper case.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #866 +/- ##
==========================================
+ Coverage 70.14% 70.63% +0.49%
==========================================
Files 95 95
Lines 15104 15077 -27
==========================================
+ Hits 10594 10649 +55
+ Misses 3785 3704 -81
+ Partials 725 724 -1
|
TaoZou1
approved these changes
Nov 5, 2024
/e2e |
zhengxiexie
approved these changes
Nov 5, 2024
timdengyun
added a commit
to timdengyun/nsx-operator-1
that referenced
this pull request
Nov 5, 2024
Based on golang Golang convention: https://go.dev/wiki/CodeReviewComments#error-strings it should make the first letter of the log message sentence as upper case.
timdengyun
added a commit
that referenced
this pull request
Nov 5, 2024
Based on golang Golang convention: https://go.dev/wiki/CodeReviewComments#error-strings it should make the first letter of the log message sentence as upper case.
wenqiq
pushed a commit
to wenqiq/nsx-operator
that referenced
this pull request
Nov 5, 2024
Based on golang Golang convention: https://go.dev/wiki/CodeReviewComments#error-strings it should make the first letter of the log message sentence as upper case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on golang Golang convention:
https://go.dev/wiki/CodeReviewComments#error-strings,
it should make the first letter of the log message sentence as upper case.