Switch to standalone cobra-cli dependency #4373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
Thanks for the reference (wow, quite an organised update!).
As mentioned on the referenced issue, we also don't really use the cobra cli except in rare cases of adding another command, so we may later remove it. But happy to see this landed for now and unblock your work. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Switches to use the extracted
cobra-clicommand since it is being removed from thegithub.aaakk.us.kg/spf13/cobramodule (xref spf13/cobra#1597)Benefits
Makefile and docs will continue to be accurate after spf13/cobra#1597 is completed
Possible drawbacks
Applicable issues
xref spf13/cobra#1597