Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated wait-check-interval default value to 3s #637

Merged
merged 1 commit into from
Nov 14, 2022
Merged

updated wait-check-interval default value to 3s #637

merged 1 commit into from
Nov 14, 2022

Conversation

kumaritanushree
Copy link
Contributor

@kumaritanushree kumaritanushree commented Nov 14, 2022 •
edited by 100mik
Loading

What this PR does / why we need it:

updated wait-check-interval default value to 3s

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?

Default wait-check-interval duration is now increased to 3s from 1s.

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:

praveenrewar
praveenrewar approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
(Just updated the release note section a bit)

100mik
100mik approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@100mik 100mik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

sethiyash
sethiyash approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@sethiyash sethiyash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@praveenrewar praveenrewar merged commit 639e9e0 into develop Nov 14, 2022
@kumaritanushree kumaritanushree mentioned this pull request Nov 29, 2022
Open
12 tasks
@praveenrewar praveenrewar deleted the update-wait-check-interval branch March 28, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@100mik 100mik 100mik approved these changes

@sethiyash sethiyash sethiyash approved these changes

@praveenrewar praveenrewar praveenrewar approved these changes

@renuy renuy Awaiting requested review from renuy

@rohitagg2020 rohitagg2020 Awaiting requested review from rohitagg2020

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kumaritanushree @praveenrewar @sethiyash @100mik @vmwclabot