Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete wasm_runtime.so integration tests #63

Open
gzurl opened this issue Jul 25, 2023 · 9 comments
Open

Complete wasm_runtime.so integration tests #63

gzurl opened this issue Jul 25, 2023 · 9 comments
Labels
👋 good first issue Good for newcomers 🧪 testing Issues related to testing (unit tests, E2E testing, ...)

Comments

@gzurl
Copy link
Contributor

gzurl commented Jul 25, 2023

Is your feature request related to a problem? Please describe.

The wasm_runtime.so Rust library is at the core of mod_wasm.
https://github.com/vmware-labs/mod_wasm/tree/main/wasm_runtime/src

Beyond unit tests (described at #62), integration tests are also needed to harden its stability.

Describe the solution you'd like

The integration tests should invoke all functions in the C API (see c_api.rs).

Originally, minimal integration tests were included only for wasm_config_create():
https://github.com/vmware-labs/mod_wasm/blob/main/wasm_runtime/tests/integration_tests.rs

The integration tests for this library should be increased for all the functions in the C API.

Describe alternatives you've considered

No response

Additional context

No response

@gzurl gzurl added 👋 good first issue Good for newcomers 🧪 testing Issues related to testing (unit tests, E2E testing, ...) labels Jul 25, 2023
@smittynewton
Copy link

This runtime is a life saver. Can now run python games made in renpy. Thank you all!

@smittynewton
Copy link

smittynewton commented Sep 21, 2023

What ubuntu version are you using in this build? I'm using 22.04 and it freezes when compiling wasm_runtime at step 292/294. Works on CentOS 7 tho. Weird..

@gzurl
Copy link
Contributor Author

gzurl commented Sep 21, 2023

What ubuntu version are you using in this build? I'm using 22.04 and it freezes when compiling wasm_runtime at step 292/294. Works on CentOS 7 tho. Weird..

@smittynewton to build wasm_runtime you can use the Rust official Docker image which is Debian-based. We use it here: https://github.com/vmware-labs/mod_wasm/blob/main/image/Dockerfile

@ereslibre
Copy link
Contributor

What ubuntu version are you using in this build? I'm using 22.04 and it freezes when compiling wasm_runtime at step 292/294. Works on CentOS 7 tho. Weird..

Hi @smittynewton, thank you for your interest in mod_wasm! Would you mind opening a new issue that contains details about your setup, and the exact problem that you are experiencing? Thank you!

@smittynewton
Copy link

I deleted the wasm_runtime folder and uploaded a fresh copy of the wasm_runtime folder and restarted server and it worked fine, thank you all! =-)

@smittynewton
Copy link

Does this mean I have to build php apache .so mod and every other mod I want to use with apache? I'm having trouble with using a built apache because it seems like every module has to be compiled with apache to get a .so in order to use it with apache. Am I doing something wrong?

@ereslibre
Copy link
Contributor

Does this mean I have to build php apache .so mod and every other mod I want to use with apache?

As far as I understand this should not be the case. We are using the DSO support from Apache, and the ABI is supposed to be compatible as long as the Apache major version does not change.

In principle, you should be able to build mod_wasm against a specific major version of Apache, and load that object on a different Apache installation (e.g. installed through system package management), as long as the major version of Apache matches.

@smittynewton
Copy link

Your right bro I rebuilt it with Amazon Linux 2023 httpd version then installed Amazon Linux 2023 httpd system package and it works! Much love bro, peace and power to you. Many thanks.

@ereslibre
Copy link
Contributor

@smittynewton out of curiosity, what kind of workloads are you running on top of mod_wasm? We would love to understand what is your main use case, and if there is anything we can do to improve mod_wasm for our users :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👋 good first issue Good for newcomers 🧪 testing Issues related to testing (unit tests, E2E testing, ...)
Projects
None yet
Development

No branches or pull requests

3 participants