Implement edit and remove API capability for dvswitch resource

[ggeldenhuis]

When creating a dvswitch in the following manner:

    vcenter::dvswitch{ "${dvswitch_fqdn}:${esxServer}":
      ensure    => present,
      transport => Transport['vcenter'],
      spec => {
        host => [
          {
            host => $esxServer,
            operation => 'add',
          }
        ]
      }
    }

The operation is always add. This sorta breaks the idempotency concept in puppet and potentially if possibly the type/provider should take care of the operation type. The API also supports edit and remove.

[maniacmurphy]

I spent some time looking into this. It looks like the current DVS map accounts for the host property by mapping the it to the DistributedVirtualSwitchHostMemberConfigSpec. The dynamic nature of the vc_dvswitch provider doesn't account for the concept of add, edit and remove required by the DistributedVirtualSwitchHostMemberConfigSpec.

I think we have two options. Either overload the getter and setter methods for the host property, or create a new resource type like vc_dvswitch_host which supports the concept of adding, editing and removing hosts. I am not sure which at the moment. Any thoughts out there?

[rbbrown]

This is not an entirely new issue -- see #106

The implementation of DistributedVirtualSwitchHostMemberConfigSpec is dynamic, based on interpreting the WSDL. I believe the implementation does support all values of operation -- iirc, I tested it -- though I don't have the capability to retest that at the moment.

I think if you try edit and remove, they will "work". Of course, as issue 106 points out, it's quite inconvenient, since the manifest has to be modified once it has run, as neither add nor remove can be idempotent. (Even 'edit', while idempotent, could slow down a run with a lot of back-and-forth to the vSphere API for each host, given the (agentless) proxy mode used for vSphere management.)

The implementation is dynamically based on the WSDL, and trying to fit in a new parameter that's not in the WSDL (say, puppet_ensure) to replace operation, would be difficult.