Skip to content
This repository has been archived by the owner on Nov 17, 2021. It is now read-only.

add last-applied strategy for diff #303

Merged

Conversation

gaurav517
Copy link

No description provided.

@gaurav517 gaurav517 force-pushed the kubecfg-diff-last-applied-strategy branch from fc1d72d to a75aabc Compare May 8, 2021 07:49
@gaurav517 gaurav517 marked this pull request as draft May 8, 2021 07:50
@gaurav517 gaurav517 marked this pull request as ready for review May 8, 2021 08:16
@gaurav517
Copy link
Author

There is little bug, let me fix that.

@gaurav517 gaurav517 marked this pull request as draft May 8, 2021 08:42
@gaurav517 gaurav517 force-pushed the kubecfg-diff-last-applied-strategy branch from a75aabc to cc67a74 Compare May 8, 2021 09:01
@gaurav517 gaurav517 marked this pull request as ready for review May 8, 2021 09:03
@gaurav517
Copy link
Author

Fixed.

@mkmik
Copy link
Contributor

mkmik commented May 8, 2021

Always wanted this thanks!

  1. Would it be possible to add some tests?

  2. What last-applied annotation is this? The kubecfg one or the kubectl one?

@gaurav517
Copy link
Author

I will try to get my head around tests tomorrow.

This last-applied annotation is kubectl one.

@gaurav517 gaurav517 force-pushed the kubecfg-diff-last-applied-strategy branch from cc67a74 to 31781f2 Compare May 9, 2021 03:51
@gaurav517
Copy link
Author

Added test and did some refactors to make changes test friendly.

@gaurav517
Copy link
Author

Thanks for releasing this. Can we update brew formula as well? Thanks.

@mkmik
Copy link
Contributor

mkmik commented May 11, 2021

the brew formula is updated by somebody in the community; I don't know how to do it (it usually just happens within a day or little bit more).

@gaurav517
Copy link
Author

cool thanks. Its updated already. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants