Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Settings: layout for Text Margins setting #2098

Closed
HeyMyian opened this issue Nov 13, 2024 · 5 comments · Fixed by #2102
Closed

Build Settings: layout for Text Margins setting #2098

HeyMyian opened this issue Nov 13, 2024 · 5 comments · Fixed by #2102
Labels
build tool Component: Exports or the build tool enhancement Request: New feature or improvement next release Note: Features planned for next release

Comments

@HeyMyian
Copy link
Contributor

2.6 Beta 1

Great new stuff 😃

I've got a suggestion for the interface in the build settings. The view in the screenshot could maybe best be understood as a table in which the column headers for the last two colums are "top" and "bottom". I guess "T" and "B" are abbreviated because of space issues; turning them into headers might alleviate that. Maybe there are languages where this can't be abbreviated.

Then there would also be space for the unit, which is currently missing.

2024-11-13___07_56_29

(I have no idea how to title this issue)

@vkbo
Copy link
Owner

vkbo commented Nov 13, 2024

Such titles are not possible with the current layout implementation as there is no way to align them with the boxes below. Although they look like they're on a grid, they are not. Each set of controls are aligned completely independently.

I've considered replacing the "T:" and "B:" with icons instead, but need to design them.

The unit is missing because it depends on the output. In most cases it's unitless and just a scale factor of either text size, or some other font-related metric, or even a reference line height. I plan to make them consistent across formats and all map to em, but the internal document format used for preview and PDF, and ODT, DocX and HTML all behave slightly differently.

@vkbo vkbo added this to the Release 2.6 RC 1 milestone Nov 13, 2024
@vkbo vkbo added enhancement Request: New feature or improvement build tool Component: Exports or the build tool labels Nov 13, 2024
@vkbo
Copy link
Owner

vkbo commented Nov 13, 2024

In #2102 I'm refactoring how text margins are applied so that they are always in em units. Only DocX used em units, as it specifies its margins as 20 times the font point size. It's a weird unit, but it avoids decimal numbers.

ODT uses physical units, so they have to be converted from DPI (72 for documents) to whatever unit is preferred. novelWriter uses centimetres internally. For HTML the unit is just em, so that's easy.

@vkbo
Copy link
Owner

vkbo commented Nov 13, 2024

Is this better?
image

@HeyMyian
Copy link
Contributor Author

I like it better than T: and B:. The icons look nice.

@vkbo
Copy link
Owner

vkbo commented Nov 13, 2024

Ok, done tweaking them. Here's the latest.

image

image

@vkbo vkbo added the next release Note: Features planned for next release label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build tool Component: Exports or the build tool enhancement Request: New feature or improvement next release Note: Features planned for next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants