Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport memory cleanup from 2.5 to 2.4 #1903

Closed
vkbo opened this issue May 30, 2024 · 0 comments · Fixed by #1905
Closed

Backport memory cleanup from 2.5 to 2.4 #1903

vkbo opened this issue May 30, 2024 · 0 comments · Fixed by #1905
Labels
bug Issue: Something isn't working build tool Component: Exports or the build tool
Milestone

Comments

@vkbo
Copy link
Owner

vkbo commented May 30, 2024

The memory cleanup changes made in 2.5 probably should be backported to 2.4. The old implementation does cause crashes occasionally when closing the Manuscript Build tool too early (before the document was rendered) due to it being triggered by a timer.

This timer does not exist in 2.4, but there is a timer that triggers the update of the yellow banner that also can crash if the dialog is closed while it's being updated. This is a tiny target window to hit, since it is very quick, but I have managed to hit it.

@vkbo vkbo added this to the Release 2.4.4 milestone May 30, 2024
@vkbo vkbo added bug Issue: Something isn't working build tool Component: Exports or the build tool labels May 30, 2024
@vkbo vkbo linked a pull request May 30, 2024 that will close this issue
6 tasks
@vkbo vkbo closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue: Something isn't working build tool Component: Exports or the build tool
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant