Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Search Enhancements #1830

Closed
awqk opened this issue Apr 23, 2024 · 4 comments · Fixed by #1936
Closed

Global Search Enhancements #1830

awqk opened this issue Apr 23, 2024 · 4 comments · Fixed by #1936
Labels
enhancement Request: New feature or improvement project management Component: Project or Project Tree

Comments

@awqk
Copy link

awqk commented Apr 23, 2024

Created an issue from earlier discussion (#1798):

  • global search panel: add some preceding context in global search matches (full word or even more?)
  • improve/fix automatic update of the search panel

plus suggestion:

  • start search without extra click on the magnifying glass after the follwing events:
    • Ctrl+Shift+F with selected text non-empty
    • button events: case sensitive on/off, whole word on/off, regex on/off
@vkbo
Copy link
Owner

vkbo commented Apr 26, 2024

  • Ctrl+Shift+F with selected text non-empty

Pressing Ctrl+Shift+F and then Enter will achieve this, so I'm not sure I see the need.

  • button events: case sensitive on/off, whole word on/off, regex on/off

The first two seems useful. I was going to add this before the release, but didn't get around to it. RegEx is a different search format, so maybe less useful.

@vkbo vkbo added enhancement Request: New feature or improvement project management Component: Project or Project Tree labels Apr 26, 2024
@awqk
Copy link
Author

awqk commented Apr 27, 2024

Pressing Ctrl+Shift+F and then Enter will achieve this, so I'm not sure I see the need.

  1. VSCode does it. 2. It doesn't hurt. 3. I don't like pressing keys when I am not yet sure where the focus is.

I was going to add this before the release, but didn't get around to it.

I know. What is the proper way you want to keep track of the small things? Let's say a small thing is not very important, involves only a few lines of code, and should be done some time down the road.

@vkbo
Copy link
Owner

vkbo commented Apr 27, 2024

I know. What is the proper way you want to keep track of the small things? Let's say a small thing is not very important, involves only a few lines of code, and should be done some time down the road.

I prefer separate issues for separate features. I organise them into release milestones as tasks, so it makes it easier to throw in minor things into releases when I have the time. Small issues, even one-liners in terms of code change, is fine.

For instance, the "plus suggestions" in the original post here could be in a separate issue since they only require a line here and there to trigger a refresh in the already existing signal handlers for the button clicks.

@vkbo vkbo added this to the Release 2.5 RC 1 milestone Jun 1, 2024
@vkbo
Copy link
Owner

vkbo commented Jun 16, 2024

I think I managed to get it to include the whole leading word. It's a bit tricky because it has to first find the preceding line break, then preceding space. It needs some real life testing in case there are corner cases I haven't thought of yet.

image

@vkbo vkbo mentioned this issue Jun 16, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request: New feature or improvement project management Component: Project or Project Tree
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants