Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config file change doesn't trigger re-run in workspace #5327

Closed
6 tasks done
hi-ogawa opened this issue Mar 3, 2024 · 1 comment · Fixed by #6859
Closed
6 tasks done

config file change doesn't trigger re-run in workspace #5327

hi-ogawa opened this issue Mar 3, 2024 · 1 comment · Fixed by #6859
Labels
feat: workspace Issues and PRs related to the workspace feature p3-minor-bug An edge case that only affects very specific usage (priority)

Comments

@hi-ogawa
Copy link
Contributor

hi-ogawa commented Mar 3, 2024

Describe the bug

In the reproduction, changing neither vitest.workspace.ts nor packages/*/vite.config.ts doesn't trigger rerun. I thought this is a part of forceRerunTriggers https://vitest.dev/config/#forcereruntriggers, but it doesn't see the case.

Reproduction

https://stackblitz.com/edit/vitest-dev-vitest-tkdqry?file=packages%2Flib2%2Fvite.config.ts

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.18.0 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.3 - /usr/local/bin/pnpm
  npmPackages:
    @vitest/ui: latest => 1.3.1 
    vite: latest => 5.1.4 
    vitest: latest => 1.3.1

Used Package Manager

npm

Validations

@hi-ogawa hi-ogawa added pending triage feat: workspace Issues and PRs related to the workspace feature p3-minor-bug An edge case that only affects very specific usage (priority) and removed pending triage labels Mar 3, 2024
@sheremet-va
Copy link
Member

The change of the config should restart the Vite server first, not just rerun the tests. Otherwise, the config won't be resolved correctly.

@sheremet-va sheremet-va moved this to Approved in Team Board Oct 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat: workspace Issues and PRs related to the workspace feature p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants