Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

happy-dom integration does not uses environmentOptions #3903

Closed
6 tasks done
raulfdm opened this issue Aug 7, 2023 · 1 comment · Fixed by #3972
Closed
6 tasks done

happy-dom integration does not uses environmentOptions #3903

raulfdm opened this issue Aug 7, 2023 · 1 comment · Fixed by #3972
Labels
enhancement New feature or request pr welcome

Comments

@raulfdm
Copy link
Contributor

raulfdm commented Aug 7, 2023

Describe the bug

I notice that while using environment: 'happy-dom', the values passed via environmentOptions are not being forward, forcing the users to define settings after it's being already initialized (e.g., via setupFiles)

Reproduction

https://stackblitz.com/edit/vitest-dev-vitest-v3zosm?file=vite.config.ts&initialPath=__vitest__/

System Info

System:
    OS: macOS 13.5
    CPU: (8) arm64 Apple M1 Pro
    Memory: 48.19 MB / 16.00 GB
    Shell: 5.9 - /opt/homebrew/bin/zsh
  Binaries:
    Node: 16.20.1 - ~/.volta/tools/image/node/16.20.1/bin/node
    npm: 8.19.4 - ~/.volta/tools/image/node/16.20.1/bin/npm
    pnpm: 8.6.6 - ~/.volta/tools/image/pnpm/8.6.6/bin/pnpm
  Browsers:
    Brave Browser: 115.1.56.14
    Chrome: 115.0.5790.114
    Edge: 115.0.1901.188
    Safari: 16.6
  npmPackages:
    @vitejs/plugin-react-swc: 3.3.2 => 3.3.2 
    @vitest/coverage-c8: 0.31.4 => 0.31.4 
    vite: 4.4.8 => 4.4.8 
    vitest: 0.31.4 => 0.31.4

Used Package Manager

pnpm

Validations

@stackblitz
Copy link

stackblitz bot commented Aug 7, 2023

Fix this issue in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request pr welcome
Projects
None yet
2 participants