fix(browser): fix console.time with fake timers (#7207)

vitest-dev · Jan 13, 2025 · 903f3b9 · 903f3b9
1 parent 9175836
commit 903f3b9
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/packages/browser/src/client/tester/logger.ts b/packages/browser/src/client/tester/logger.ts
@@ -2,7 +2,7 @@ import { format, stringify } from 'vitest/utils'
 import { getConfig } from '../utils'
 import { rpc } from './rpc'
 
-const { Date, console } = globalThis
+const { Date, console, performance } = globalThis
 
 export function setupConsoleLogSpy() {
   const {
@@ -71,7 +71,7 @@ export function setupConsoleLogSpy() {
     if (!(label in timeLabels)) {
       sendLog('stderr', `Timer "${label}" does not exist`)
     }
-    else if (start) {
+    else if (typeof start !== 'undefined') {
       const duration = end - start
       sendLog('stdout', `${label}: ${duration} ms`)
     }

diff --git a/test/browser/specs/runner.test.ts b/test/browser/specs/runner.test.ts
@@ -90,6 +90,8 @@ describe('running browser tests', async () => {
     expect(stdout).toContain('count: 3')
     expect(stdout).toMatch(/default: [\d.]+ ms/)
     expect(stdout).toMatch(/time: [\d.]+ ms/)
+    expect(stdout).toMatch(/\[console-time-fake\]: [\d.]+ ms/)
+    expect(stdout).not.toContain('[console-time-fake]: 0 ms')
   })
 
   test('logs are redirected to stderr', () => {

diff --git a/test/browser/test/timers.test.ts b/test/browser/test/timers.test.ts
@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import { afterEach, expect, it, vi } from 'vitest'
 
 afterEach(() => {
@@ -17,3 +18,12 @@ it('only runs a setTimeout callback once (ever)', () => {
   vi.runAllTimers()
   expect(fn).toHaveBeenCalledTimes(1)
 })
+
+it('console.time', async () => {
+  vi.useFakeTimers({
+    toFake: ['Date', 'performance'],
+  })
+  console.time('[console-time-fake]')
+  await new Promise(r => setTimeout(r, 500))
+  console.timeEnd('[console-time-fake]')
+})