Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin] Add support to vtadmin/grpcserver for additional service healthchecks #7634

Closed
ajm188 opened this issue Mar 8, 2021 · 0 comments · Fixed by #7635
Closed

[vtadmin] Add support to vtadmin/grpcserver for additional service healthchecks #7634

ajm188 opened this issue Mar 8, 2021 · 0 comments · Fixed by #7635
Assignees
Labels
Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature)

Comments

@ajm188
Copy link
Contributor

ajm188 commented Mar 8, 2021

This refers to this code specifically:

	// (TODO:@amason) Figure out a good abstraction to have other services
	// register themselves.
	s.healthServer.SetServingStatus("grpc.health.v1.Health", healthpb.HealthCheckResponse_SERVING)

The immediate use case of this is to add vtadmin.VTAdminServer to the set of services whose health status can be queried, and the longer-term use case is to potentially support plugins in vtadmin by including them in the list of rpc services handled by vtadmin-api's grpcserver.

@ajm188 ajm188 added P3 Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VTAdmin VTadmin interface labels Mar 8, 2021
@ajm188 ajm188 self-assigned this Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant