Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC interface to vtctl to use #5980

Closed
guidoiaquinti opened this issue Mar 27, 2020 · 2 comments
Closed

gRPC interface to vtctl to use #5980

guidoiaquinti opened this issue Mar 27, 2020 · 2 comments

Comments

@guidoiaquinti
Copy link
Member

Pulling this out from an internal conversation

Feature Description

Provide well-defined grpc interface to vtctl to use

Use Case(s)

We were looking at moving some of our operational tooling for Vitess to go, and we noticed that there isn’t a “true” interface into the vtctld in the protobuf definition. While there is a grpc endpoint, it’s not well defined, as it’s mainly a passthrough to all of the different vtctld methods.

For example, instead of there being a FindAllShardsInKeyspace endpoint, we instead call vtctlclient.ExecuteVtctlCommand(vtctldata.ExecuteVtctlCommandRequest{Args: []string{"FindAllShardsInKeyspace", "keyspace_name"}}) and then parse the response into our own user-defined structs, instead of having structs in the .pb.go file that we can use instead.

Quoting @sougou

I've been having similar thoughts, but right now is not a good time. The deprecation of SBR, v2 and old resharding workflows are going to drastically change the list of commands available through vtctld. We can look at doing this after all this stabilizes.

@derekperkins
Copy link
Member

We found this out too and it makes tooling more difficult. Having a real API will also make the new UI much easier to build.

@ajm188
Copy link
Contributor

ajm188 commented Sep 9, 2021

This is a dupe of #7058, I'm going to close this one.

@ajm188 ajm188 closed this as completed Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants