Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vttop / simplify build structure #5378

Closed
morgo opened this issue Oct 30, 2019 · 0 comments · Fixed by #5527
Closed

Remove vttop / simplify build structure #5378

morgo opened this issue Oct 30, 2019 · 0 comments · Fixed by #5527
Assignees
@morgo
Labels
Type: Enhancement Logical improvement (somewhere between a bug and feature)
Milestone
v5.0

Comments

@morgo
Copy link
Contributor

morgo commented Oct 30, 2019 •
edited
Loading

Feature Description

As discussed on the monthly Vitess call, we should simplify the build structure of Vitess. So currently there is VTROOT, which requires a subdirectory of structure src/vitess.io/vitess inside it.

VTROOT + this src/vitess.io/vitess = VTTOP.

The proposal is to set VTROOT to what is currently VTTOP, and then eliminate VTTOP. This will allow someone to check out and build Vitess as follows:

git clone [email protected]:vitessio/vitess.git
cd vitess
make build

cd examples/local
./101_initial_cluster.sh
@morgo morgo added the Type: Enhancement Logical improvement (somewhere between a bug and feature) label Oct 30, 2019
@morgo morgo added this to the v5.0 milestone Nov 4, 2019
@morgo morgo self-assigned this Nov 4, 2019
@morgo morgo mentioned this issue Nov 5, 2019
Closed
@morgo morgo mentioned this issue Dec 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@morgo morgo

Labels
Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v5.0
1 participant
@morgo