Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Allow overriding the shutdown time for upgrade safe backups #17920

Open
dbussink opened this issue Mar 6, 2025 · 0 comments · May be fixed by #17923
Open

Feature Request: Allow overriding the shutdown time for upgrade safe backups #17920

dbussink opened this issue Mar 6, 2025 · 0 comments · May be fixed by #17923
Assignees
@dbussink
Labels
Component: Backup and Restore Type: Enhancement Logical improvement (somewhere between a bug and feature)

Comments

@dbussink
Copy link
Contributor

dbussink commented Mar 6, 2025

Feature Description

Upgrade safe backups set innodb_fast_shutdown=0, which means they can take longer to actually shut down. This can cause a problem when executing a BackupShard, where the normal shutdown is fine for regular operation, but it fails when doing the backup with UpgradeSafe set.

In those cases, you don't want to change the global setting for all normal operations, but just the specific shutdown for the given BackupShard command.

Use Case(s)

Allow for successful upgrade safe backups.
@dbussink dbussink added the Needs Triage This issue needs to be correctly labelled and triaged label Mar 6, 2025
@dbussink dbussink self-assigned this Mar 6, 2025
@dbussink dbussink added Component: Backup and Restore Type: Enhancement Logical improvement (somewhere between a bug and feature) and removed Needs Triage This issue needs to be correctly labelled and triaged labels Mar 6, 2025
@dbussink dbussink linked a pull request Mar 6, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbussink dbussink

Labels
Component: Backup and Restore Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow for specifying a specific MySQL shutdown timeout planetscale/vitess
1 participant
@dbussink