Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema.Engine: need to improve on tables-with-sizes query #17119

Closed
shlomi-noach opened this issue Oct 30, 2024 · 0 comments · Fixed by #17118
Closed

schema.Engine: need to improve on tables-with-sizes query #17119

shlomi-noach opened this issue Oct 30, 2024 · 0 comments · Fixed by #17118
Assignees
Labels
Component: schema management schemadiff and schema changes Type: Enhancement Logical improvement (somewhere between a bug and feature)

Comments

@shlomi-noach
Copy link
Contributor

In #17066 we made substantial performance improvements to TablesWithSize80. During that work, we noticed the query does not cover all data.

As a reminder, this query is used to determine the total file size and allocated size (as reported by InnoDB) for all InnoDB tables. We focus on MySQL 8.0 here as there are other implementations for different versions.

What we noticed is we do not account for FULLTEXT indexes. These are not BTREEs; a FULLTEXT index is implemented by hidden InnoDB tables. Our query does not measure the file/allocated size for those tables.

Getting to read those sizes complicates the query even more, as it requires the introduction of information_schema.innodb_tables which helps us decipher which hidden InnoDB table belongs to which FULLTEXT-enabled table.

The objective is to read those table dimensions, while still maintaining good performance, in the same scale as that we achieved in #17066.

@shlomi-noach shlomi-noach added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: schema management schemadiff and schema changes labels Oct 30, 2024
@shlomi-noach shlomi-noach self-assigned this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: schema management schemadiff and schema changes Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant