Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Report: Query plan cache misses metric incorrect #16592

Closed
shanth96 opened this issue Aug 13, 2024 · 0 comments · Fixed by #16562
Closed

Bug Report: Query plan cache misses metric incorrect #16592

shanth96 opened this issue Aug 13, 2024 · 0 comments · Fixed by #16562
Labels
Component: Query Serving Type: Bug

Comments

@shanth96
Copy link
Contributor

Overview of the Issue

Looks like the vtgate QueryPlanCacheMisses metric is reporting incorrect values. Specifically, it looks like it's reporting the cache hits instead of misses.

Reproduction Steps

  1. Run vtgate
  2. Compare QueryPlanCacheMisses and QueryPlanCacheHits metric to see that they are the exact same metric.

Binary Version

v18+ is affected

Operating System and Environment details

n/a

Log Fragments

No response
@shanth96 shanth96 added Needs Triage This issue needs to be correctly labelled and triaged Type: Bug labels Aug 13, 2024
@shanth96 shanth96 mentioned this issue Aug 13, 2024
Merged
5 tasks
@GuptaManan100 GuptaManan100 added Component: Query Serving and removed Needs Triage This issue needs to be correctly labelled and triaged labels Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix query plan cache misses metric Shopify/vitess
2 participants
@GuptaManan100 @shanth96