Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VTAdmin to use VTGate's vexplain #16412

Closed
notfelineit opened this issue Jul 16, 2024 · 2 comments · Fixed by #17508
Closed

VTAdmin to use VTGate's vexplain #16412

notfelineit opened this issue Jul 16, 2024 · 2 comments · Fixed by #17508
Assignees
@notfelineit
Labels
Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature)

Comments

@notfelineit
Copy link
Contributor

notfelineit commented Jul 16, 2024 •
edited by deepthi
Loading

VTAdmin's VTExplain feature currently uses VTExplain directly, instead of VTGate's vexplain. We should use VTGate's methods when possible, or vtctld.
@notfelineit notfelineit added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VTAdmin VTadmin interface labels Jul 16, 2024
@notfelineit notfelineit self-assigned this Jul 16, 2024
@deepthi deepthi changed the title VTExplain to use VTGate's VTExplain VTExplain to use VTGate's vexplain Jul 16, 2024
@deepthi
Copy link
Member

deepthi commented Jul 16, 2024

I'm not sure if VTAdmin has a sql connection to vtgates. That would be required in order to use the vexplain syntax, which is Vitess-specific syntax that vtgate understands.

@notfelineit
Copy link
Contributor Author

@deepthi we might actually! The tablets for example, are fetched via this query through VTGate: https://github.com/vitessio/vitess/blob/main/go/vt/vtadmin/vtsql/vtsql.go#L174

Was that what you meant?

@deepthi deepthi changed the title VTExplain to use VTGate's vexplain VTAdmin to use VTGate's vexplain Jul 16, 2024
@github-project-automation github-project-automation bot moved this to To do soon-ish (planned but not started) in VTAdmin Aug 29, 2024
@c-r-dev c-r-dev mentioned this issue Jan 13, 2025
Merged
5 tasks
@github-project-automation github-project-automation bot moved this from To do soon-ish (planned but not started) to Done in VTAdmin Jan 28, 2025
@c-r-dev c-r-dev mentioned this issue Feb 5, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@notfelineit notfelineit

Labels
Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
VTAdmin
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

VTAdmin to use VTGate's vexplain c-r-dev/vitess
2 participants
@deepthi @notfelineit