Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some errors in SwitchWrites are not handled properly #14801

Closed
rohit-nayak-ps opened this issue Dec 18, 2023 · 0 comments · Fixed by #14800
Closed

Some errors in SwitchWrites are not handled properly #14801

rohit-nayak-ps opened this issue Dec 18, 2023 · 0 comments · Fixed by #14800
Assignees
@rohit-nayak-ps
Labels
Component: VReplication Type: Bug

Comments

@rohit-nayak-ps
Copy link
Contributor

rohit-nayak-ps commented Dec 18, 2023 •
edited
Loading

Overview of the Issue

In #13656 one commit added a helper function to log errors, but as part of it some locations where the helper was called was not returning the error back to the caller.

Errant commit: 89295b5#diff-a071a972abd45af831ed93cc6447a87b83cee112f1c7d3bb0bdd592979d80c91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohit-nayak-ps rohit-nayak-ps

Labels
Component: VReplication Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

VReplication SwitchWrites: Properly return errors in SwitchWrites planetscale/vitess
1 participant
@rohit-nayak-ps