Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Changes to make foreign key checks Vitess Aware don't work with MySQL 5.7 #14631

Closed
GuptaManan100 opened this issue Nov 29, 2023 · 1 comment

Comments

@GuptaManan100
Copy link
Member

Overview of the Issue

The changes made in #14484 to make FOREIGN_KEY_CHECKS a Vitess Aware Variable don't work with MySQL 5.7 because it doesn't support SET_VAR optimiser hints. The changes in that PR rely on the optimiser hint working since they replace SET FOREIGN_KEY_CHECKS commands to instead set optimiser hints on the subsequent queries.

Reproduction Steps

Run the latest vitess code from main.
Execute SET FOREIGN_KEY_CHECKS = 0 and then run a query which inserts data violating a foreign key constraint.

Binary Version

main

Operating System and Environment details

-

Log Fragments

No response

@GuptaManan100
Copy link
Member Author

We no longer intend to support MySQL 5.7 in Vitess releases from v19 onwards. We will however continue supporting importing from MySQL 5.7. The changes made to Vitess are okay for this use-case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant