Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concurrency for GetSchema calls grows with number of tables #13616

Closed
shlomi-noach opened this issue Jul 26, 2023 · 0 comments · Fixed by #13617
Closed

Concurrency for GetSchema calls grows with number of tables #13616

shlomi-noach opened this issue Jul 26, 2023 · 0 comments · Fixed by #13617
Labels
Component: TabletManager Type: Bug

Comments

@shlomi-noach
Copy link
Contributor

Currently, GetSchema opens a goroutine for each table/view in the user's schema. The concurrency is unbounded. In the scope of multiple thousands tables, combined with high latency connections, this can lead to resource exhaustion, and in particular to MySQL connection exhaustion.

There should be a reasonable concurrency limit in GetSchema.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: TabletManager Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GetSchema: limit concurrent operations planetscale/vitess
1 participant
@shlomi-noach