Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Seconds type from tabletenv to flagutil (or other appropriate package) #11891

Closed
ajm188 opened this issue Dec 6, 2022 · 0 comments · Fixed by #12920
Closed

Move Seconds type from tabletenv to flagutil (or other appropriate package) #11891

ajm188 opened this issue Dec 6, 2022 · 0 comments · Fixed by #12920

Comments

@ajm188
Copy link
Contributor

ajm188 commented Dec 6, 2022

See the discussion on this section of code.

The primary motivation for this is to avoid import cycles between tabletenv and viperutil, but more broadly, Seconds is mostly a type to provide some niceties in flag parsing, so it doesn't logically fit in tabletenv anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant