Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: appType (spa, mpa, custom), boolean middlewareMode #8452
feat!: appType (spa, mpa, custom), boolean middlewareMode #8452
Changes from 14 commits
cb78c7b
8ded69e
fc7a534
f02e229
0c3d73b
f078727
5eeeaaf
cb2869a
94c2606
2b9737b
854dc98
3818bd7
cbe8b49
50e0923
6ab220f
003e9a4
bf92941
3bd2592
a294a80
c061a02
71e4d65
dd5f669
8699c50
4fcb681
936f3b3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
middlewareMode
is a boolean nowThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for backward compat. We can break it directly for v3 thought
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they are only a handful of frameworks out there using
middlewareMode: 'ssr'
now that it should be safe to break. Otherwise another option is tolog
a warning, but framework authors would likely fix it right away so that end-users don't see it.