From da269306e7f9f227c7210e1f70b009005e32fe59 Mon Sep 17 00:00:00 2001 From: dengqing Date: Thu, 19 May 2022 08:46:07 +0800 Subject: [PATCH 1/3] feat: support set NODE_ENV in scripts --- packages/vite/src/node/config.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts index 02ce73c99a58c8..68df28a00b952f 100644 --- a/packages/vite/src/node/config.ts +++ b/packages/vite/src/node/config.ts @@ -395,7 +395,9 @@ export async function resolveConfig( // Note it is possible for user to have a custom mode, e.g. `staging` where // production-like behavior is expected. This is indicated by NODE_ENV=production // loaded from `.staging.env` and set by us as VITE_USER_NODE_ENV - const isProduction = (process.env.VITE_USER_NODE_ENV || mode) === 'production' + const isProduction = + (process.env.NODE_ENV || process.env.VITE_USER_NODE_ENV || mode) === + 'production' if (isProduction) { // in case default mode was not production and is overwritten process.env.NODE_ENV = 'production' From 7c39314eedda6001908ed5682df954de2a4828e7 Mon Sep 17 00:00:00 2001 From: dengqing Date: Fri, 20 May 2022 23:47:10 +0800 Subject: [PATCH 2/3] fix: vitest set NODE_ENV causes the test to fail --- playground/optimize-deps/vite.config.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/playground/optimize-deps/vite.config.js b/playground/optimize-deps/vite.config.js index 623cc413032fdf..d78d0098c5b09f 100644 --- a/playground/optimize-deps/vite.config.js +++ b/playground/optimize-deps/vite.config.js @@ -1,6 +1,8 @@ const fs = require('fs') const vue = require('@vitejs/plugin-vue') +process.env.NODE_ENV = '' + /** * @type {import('vite').UserConfig} */ From 120c0910da58c39b2eb59f6906bf491d5b42fe3d Mon Sep 17 00:00:00 2001 From: dengqing Date: Sat, 21 May 2022 00:25:45 +0800 Subject: [PATCH 3/3] docs: add comment --- playground/optimize-deps/vite.config.js | 1 + 1 file changed, 1 insertion(+) diff --git a/playground/optimize-deps/vite.config.js b/playground/optimize-deps/vite.config.js index d78d0098c5b09f..fb3bbfc4a33eb5 100644 --- a/playground/optimize-deps/vite.config.js +++ b/playground/optimize-deps/vite.config.js @@ -1,6 +1,7 @@ const fs = require('fs') const vue = require('@vitejs/plugin-vue') +// Overriding the NODE_ENV set by vitest process.env.NODE_ENV = '' /**